search

mozilla / perfcompare

Improved Performance Comparison Tool
Mozilla Public License 2.0
39 stars 93 forks source link

Virtualized the results table #712

Closed julienw closed 1 month ago

julienw commented 2 months ago

This is now ready for review! From my point of view, the behavior looks correct, but please test and tell me what you think!

deploy preview / beta branch

I decided to use react virtuoso because it's easy to setup and easily supports variable heights (costing some performance). I tried react-window first, but it's much more complex to implement with our constraints.

netlify[bot] commented 2 months ago

Deploy Preview for mozilla-perfcompare ready!

Name Link
Latest commit 717ed10df3501b1702817975f59a392be0e17bf6
Latest deploy log https://app.netlify.com/sites/mozilla-perfcompare/deploys/66c48c1f7b21950008906873
Deploy Preview https://deploy-preview-712--mozilla-perfcompare.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.63%. Comparing base (8579af4) to head (717ed10). Report is 1 commits behind head on beta.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## beta #712 +/- ## ========================================== + Coverage 85.62% 85.63% +0.01% ========================================== Files 83 83 Lines 2163 2165 +2 Branches 396 396 ========================================== + Hits 1852 1854 +2 Misses 274 274 Partials 37 37 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.