search

mozilla / perfcompare

Improved Performance Comparison Tool
Mozilla Public License 2.0
39 stars 93 forks source link

Fix SelectList item active and selector background colors on dark mode #725

Closed canova closed 1 month ago

canova commented 1 month ago

This fixes Bug 1913699.

Please see the STR that I mentioned in the bug. SelectList selected item active and selected background colors on dark mode were still using the light mode's color and that's why they were hard to read on a white text. This PR fixes those colors so it's easier to read them, and the UI colors are more consistent on dark mode.

Before:

Screenshot 2024-08-19 at 11 35 54 AM

After:

Screenshot 2024-08-19 at 11 46 20 AM
netlify[bot] commented 1 month ago

Deploy Preview for mozilla-perfcompare ready!

Name Link
Latest commit e345100f33d5865924e3ec14f0b76e14964a4774
Latest deploy log https://app.netlify.com/sites/mozilla-perfcompare/deploys/66c314df1704780008d3f12b
Deploy Preview https://deploy-preview-725--mozilla-perfcompare.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.62%. Comparing base (d137b7a) to head (e345100). Report is 1 commits behind head on beta.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## beta #725 +/- ## ======================================= Coverage 85.62% 85.62% ======================================= Files 83 83 Lines 2163 2163 Branches 396 396 ======================================= Hits 1852 1852 Misses 274 274 Partials 37 37 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

canova commented 1 month ago

Thanks for the review!

Note that I see a similar issue exists also in the framework dropdown, but it's more complex to fix. It's due to these cssRule('.MuiPopover-root', ... rules that are in a lot of places, that I'd like to remove and do in another way. That's for another PR though, clearly out of scope here.

Yes, I actually saw the same thing and tried to fix it, but it quickly became harder than expected because of these rules, so I stopped doing it 😄