mozilla / perfcompare

Improved Performance Comparison Tool
Mozilla Public License 2.0
39 stars 93 forks source link

Add colors to subtests and small layout changes #751

Closed julienw closed 1 month ago

julienw commented 1 month ago

This PR has 4 commits:

  1. adds colors to the subtests view.
  2. a small performance-related change about how we deal with the dark and light styles in the subtests page.
  3. change how the grid's columns are configured -- instead of an hardcoded value, it comes from the cellsConfiguration. This makes it easier to do different adjustments in the subtests view vs the main view.
  4. adjusts a little bit the layout of the results table so that the columns look more aligned.

I did all these changes here because without these changes, the color boxes in the subtests view was moving everything and this wasn't nice at all.

Production / Deploy preview

subtests page:

Before:

image

After: image

main page with no changes

Before: image

After: image

main page with improvements

Before: image

After: image

netlify[bot] commented 1 month ago

Deploy Preview for mozilla-perfcompare ready!

Name Link
Latest commit b9cd6bfaf583c3ed1485684034082f424e6a975d
Latest deploy log https://app.netlify.com/sites/mozilla-perfcompare/deploys/66e19fcc6b0e0f00084b1499
Deploy Preview https://deploy-preview-751--mozilla-perfcompare.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.39%. Comparing base (9f6d734) to head (b9cd6bf). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #751 +/- ## ========================================== + Coverage 91.34% 91.39% +0.04% ========================================== Files 85 85 Lines 2242 2254 +12 Branches 423 427 +4 ========================================== + Hits 2048 2060 +12 Misses 171 171 Partials 23 23 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.