search

mozilla / perfcompare

Improved Performance Comparison Tool
Mozilla Public License 2.0
39 stars 93 forks source link

PCF-502: increased height of results list to show first five items #758

Closed Carla-Moz closed 3 weeks ago

Carla-Moz commented 3 weeks ago

Moved specific results list styles to SearchResultsList because they were only used once in styles/SelectList Fix for issue PCF-502. Let me know if the height is satisfactory or if I should increase even more.

netlify[bot] commented 3 weeks ago

Deploy Preview for mozilla-perfcompare ready!

Name Link
Latest commit 7213f81fba77b3bb17fedca6faf147324a2b2bae
Latest deploy log https://app.netlify.com/sites/mozilla-perfcompare/deploys/66f23638cdc06f00081bd711
Deploy Preview https://deploy-preview-758--mozilla-perfcompare.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.42%. Comparing base (2f66b31) to head (7213f81). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #758 +/- ## ========================================== + Coverage 91.39% 91.42% +0.03% ========================================== Files 87 87 Lines 2254 2262 +8 Branches 421 425 +4 ========================================== + Hits 2060 2068 +8 Misses 171 171 Partials 23 23 ``` | [Flag](https://app.codecov.io/gh/mozilla/perfcompare/pull/758/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/mozilla/perfcompare/pull/758/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | `91.42% <100.00%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.