mozilla / perfcompare

Improved Performance Comparison Tool
Mozilla Public License 2.0
39 stars 93 forks source link

Increase the maximum amount of possible retriggers to 9 #760

Closed julienw closed 2 weeks ago

julienw commented 3 weeks ago

As requested by @acreskeyMoz! image

I tried using a native select so that you wouldn't have to open the select before selecting the value with the keyboard but I couldn't style it quickly properly, so I kept MUI's version for now.

netlify[bot] commented 3 weeks ago

Deploy Preview for mozilla-perfcompare ready!

Name Link
Latest commit 06f96d627858981cbc94c4a00d181d9a9d234a1d
Latest deploy log https://app.netlify.com/sites/mozilla-perfcompare/deploys/66f3f31a84b2c60008c20287
Deploy Preview https://deploy-preview-760--mozilla-perfcompare.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.42%. Comparing base (6020382) to head (06f96d6). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #760 +/- ## ======================================= Coverage 91.42% 91.42% ======================================= Files 87 87 Lines 2262 2263 +1 Branches 425 425 ======================================= + Hits 2068 2069 +1 Misses 171 171 Partials 23 23 ``` | [Flag](https://app.codecov.io/gh/mozilla/perfcompare/pull/760/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/mozilla/perfcompare/pull/760/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | `91.42% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

acreskeyMoz commented 3 weeks ago

Thank you!