search

mozilla / perfcompare

Improved Performance Comparison Tool
Mozilla Public License 2.0
39 stars 93 forks source link

Redesign the landing page after the taskcluster signin #761

Closed julienw closed 5 days ago

julienw commented 3 weeks ago

Previously, after the user signs in on taskcluster so that they can do a retrigger request, perfcompare displays a blank page while it validates the credentials. This isn't a great experience so this patch adds up some (limited) spice, especially a spinner.

image

This also adds some more tests and fixes a bug with handling errors properly (and adds a test about that).

Commit 1: updates react-router-dom because this fixes an issue with Await in the test (without that there's some infinite loop). Commit 2: make the taskcluster auth landing page asynchronous with promises and adds the spinner. Commit 3: changes the structure of the test and simplifies it a bit so that other tests can easily be added. Commit 4: adds a specific test for the spinner. Commit 5: fixes the issue with handling errors (and adds a test)

Note that you can't test the taskcluster signin from the deploy preview but you can test it by applying the patch locally. I was testing from this URL (provided you started your local server on port 3000). Make sure that your localStorage is empty (using Devtools' Storage panel) so that the sign in process will proceed.

netlify[bot] commented 3 weeks ago

Deploy Preview for mozilla-perfcompare ready!

Name Link
Latest commit 4308401782f549bda957818b178410f03e6c8f58
Latest deploy log https://app.netlify.com/sites/mozilla-perfcompare/deploys/6706711ffd44610008ea6d87
Deploy Preview https://deploy-preview-761--mozilla-perfcompare.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.59%. Comparing base (6020382) to head (3fb6516).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #761 +/- ## ========================================== + Coverage 91.42% 91.59% +0.17% ========================================== Files 87 87 Lines 2262 2273 +11 Branches 425 425 ========================================== + Hits 2068 2082 +14 + Misses 171 168 -3 Partials 23 23 ``` | [Flag](https://app.codecov.io/gh/mozilla/perfcompare/pull/761/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | Coverage Ī” | | |---|---|---| | [](https://app.codecov.io/gh/mozilla/perfcompare/pull/761/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla) | `91.59% <100.00%> (+0.17%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=mozilla#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.