Add date range to time range dropdown

mozilla / perfcompare

Improved Performance Comparison Tool

Mozilla Public License 2.0

39 stars 93 forks source link

Add date range to time range dropdown #763

Open sumairq opened 1 week ago

sumairq commented 1 week ago

Solves Bug 1922027

Description

This PR enhances the existing time range dropdown in the CompareOverTime UI by displaying specific dates alongside the predefined time range options. This provides users with better clarity on the exact date ranges they are selecting.

Changes:

Updated the time range dropdown to display specific start and end dates next to predefined options (e.g., "Last 7 days" now shows the exact dates).

Screenshot:

netlify[bot] commented 1 week ago

Deploy Preview for mozilla-perfcompare ready!

Name	Link
Latest commit	d636b8562e0f47c3192ba05edf2edfb007d113a4
Latest deploy log	https://app.netlify.com/sites/mozilla-perfcompare/deploys/670d528b3c5510000820822b
Deploy Preview	https://deploy-preview-763--mozilla-perfcompare.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.49%. Comparing base (3a555e3) to head (d636b85).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #763 +/- ## ========================================== + Coverage 91.46% 91.49% +0.02% ========================================== Files 88 88 Lines 2332 2339 +7 Branches 434 434 ========================================== + Hits 2133 2140 +7 Misses 176 176 Partials 23 23 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sumairq commented 15 hours ago

Thank you @julienw for the very high-quality and thorough review! :100: I am learning a lot from your feedback, and it has improved not only the code but also my thinking process. :brain: :raised_hands: