Open Carla-Moz opened 6 days ago
Hi, I'd like to attempt this
@FatumaA, Please go ahead and try.
@Carla-Moz what do you mean by the title?
Hi! I've implemented functionality when I enter a custom title in the input field, it updates the URL correctly and when i refresh the page, it persists. If I share the URL, the custom title is displayed as intended and the title is in the URL as well, as for me locally it shows (http://localhost:3000/compare-results?baseRev=aa73934529cc8e33ed70fd861d70456fdf7f0818&baseRepo=try&framework=1&**title=updated+title**)
However, when navigating back to the Results page from the home page, the previously entered title is not retained, and the title reverts to a default value.
My question is, Is this behavior expected, or should the custom title persist across navigations? If it's expected to retain the custom title, what changes would be necessary?
Hi! I've implemented functionality when I enter a custom title in the input field, it updates the URL correctly and when i refresh the page, it persists. If I share the URL, the custom title is displayed as intended and the title is in the URL as well, as for me locally it shows (http://localhost:3000/compare-results?baseRev=aa73934529cc8e33ed70fd861d70456fdf7f0818&baseRepo=try&framework=1&**title=updated+title**)
However, when navigating back to the Results page from the home page, the previously entered title is not retained, and the title reverts to a default value.
My question is, Is this behavior expected, or should the custom title persist across navigations? If it's expected to retain the custom title, what changes would be necessary?
Yes i think so that this is the expected behavior as stated here.
Hi Carla, I've linked my first attempt at this. Please let me know if that was what was meant and looking forward to your review
Hello, @Carla-Moz ,What title are you referring to? Did you mean this?
@claire256 from what I know, this is what page title is
@hibaa03 , thanks.
Description: As a user, I want to be able to change the title of PerfCompare and have the new title persist in the url, so that I can share the updated title with others.
Steps to Reproduce:
Acceptance Criteria:
Hint! Check out this closed PR to help you out. Persist the search term in the url #724