mozilla / perfcompare

Improved Performance Comparison Tool
Mozilla Public License 2.0
39 stars 93 forks source link

Issue # 767 Display Local Time Zones for Revisions in Search Results and Selected Revisions #770

Open hibaa03 opened 6 days ago

hibaa03 commented 6 days ago

This pull request implements the following changes close #767 :

Display Local Time Zones: Added functionality to display the local time zone alongside each revision timestamp. It shows me time in my local timezone (GMT+5) as in the screenshot below. Screenshot 2024-10-12 at 2 03 08 AM Used the day.js library witth timezone plugin to accurately retrieve and format timezone abbreviations based on the local time.

UTC Timestamp Tooltip: Introduced a tooltip that shows the UTC timestamp when hovering over the local time.

Screenshot 2024-10-12 at 2 03 28 AM

Time Zone in Selected Revision: Ensured the local time zone is also displayed for any selected revision, along with the UTC on hover through a tooltip. Image 12-10-2024 at 2 45 AM

Compactness: Displayed time and time zone in a more digestible format. Highlighted key information (time and time zone) with bold styling

netlify[bot] commented 6 days ago

Deploy Preview for mozilla-perfcompare ready!

Name Link
Latest commit 7a026fcf4986d1ec2454db5cf61bb4e74b9b5550
Latest deploy log https://app.netlify.com/sites/mozilla-perfcompare/deploys/67099bb80aaa890008477a78
Deploy Preview https://deploy-preview-770--mozilla-perfcompare.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.34%. Comparing base (74b2bc7) to head (7a026fc). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #770 +/- ## ========================================== + Coverage 91.29% 91.34% +0.05% ========================================== Files 88 88 Lines 2321 2335 +14 Branches 434 435 +1 ========================================== + Hits 2119 2133 +14 Misses 179 179 Partials 23 23 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

syedbarimanjan commented 5 days ago

Add a close #bug-number to your pr description so that if the pr gets merged the issue will close automatically.

Carla-Moz commented 4 days ago

Great effort, Hiba, however, the design requires a more compact version of the timezones. See below.

image

Your version also breaks the style for my time zone:

image

hibaa03 commented 4 days ago

Hi @Carla-Moz, I appreciate your feedback. I have made the changes accordingly, could you please review it when possible?