search

mozilla / perfcompare

Improved Performance Comparison Tool
Mozilla Public License 2.0
39 stars 93 forks source link

Set High Confidence as Default Filter in Results Table #784

Open crocmons opened 4 days ago

crocmons commented 4 days ago

This Pr Resolves this issue - #766

Default Filter Settings: Updated the filtering logic to set "High" as the default selected confidence level. This change ensures that when the results table is loaded, it will only display high-confidence results first, aligning with user expectations.

Filter Toggle Logic: Adjusted the logic for toggling filters to ensure that only the selected confidence levels are displayed. If "High" is selected, only high-confidence results will be visible initially, while "Medium" and "Low" results will remain hidden until explicitly selected by the user.

Testing Steps

  1. Navigate to the results table in the application.
  2. Verify that high-confidence results are displayed by default upon loading the table.
  3. Test the filter functionality by selecting "Medium" and "Low" to ensure that only the corresponding results are shown.
  4. Confirm that re-selecting "High" brings back the high-confidence results.

Expected Outcome

With these changes, users should now experience a more intuitive results view, with high-confidence results prioritized, thus improving the overall usability of the application.

Demo:

Screenshot - 2024-10-11T035630 855

netlify[bot] commented 4 days ago

Deploy Preview for mozilla-perfcompare ready!

Name Link
Latest commit a8529613a7a24f7eb53862bf4c348540b3a9e786
Latest deploy log https://app.netlify.com/sites/mozilla-perfcompare/deploys/6708e48863c15d00084e64c5
Deploy Preview https://deploy-preview-784--mozilla-perfcompare.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

crocmons commented 3 days ago

@Carla-Moz hi can you help me with that how can I fix these test cases?

hibaa03 commented 3 days ago

Hi, for the CI tests failing read this part of the README. Make sure the snapshots are updated by running npm test -- -u

osujipius commented 3 days ago

@Carla-Moz hi can you help me with that how can I fix these test cases?

Try running this: npm run test-all npm run fix-all