Open Dorcas-BD opened 3 days ago
Name | Link |
---|---|
Latest commit | 6ee836fad4902da3f564761c9d056fbc47d9f42e |
Latest deploy log | https://app.netlify.com/sites/mozilla-perfcompare/deploys/670e0a66273f110008d453a6 |
Deploy Preview | https://deploy-preview-786--mozilla-perfcompare.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.53%. Comparing base (
3a555e3
) to head (6ee836f
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hello @Carla-Moz, I’ve updated the code to use whole words instead of initials as suggested. Please take a look at the changes!
This pull request addresses the issue (#765) where the filters applied to the results table were not persisted in the URL, resulting in the default view being restored upon page refresh. With this update, users can now expect the following behavior:
Implementation Details
The following changes were made to implement the persistence of filters:
Effect Hook for Initial Filters:
useEffect
hook initialises the filters based on the current URL search parameters. If no parameters are found, it defaults to using the possible values for each filter.initialFilters
state is set accordingly to reflect the current filter configuration.Filter Clearing Functionality:
onClearFilter
function was updated to ensure that when a filter is cleared, the URL is also updated to reflect all possible values.Filter Toggling Functionality:
onToggleFilter
function ensures that when filters are toggled, the URL parameters are updated accordingly to maintain consistency with the displayed results.Screenshots Showing Changes Made
Before Changes
After Changes
Platform
Status
Confidence
Steps to Reproduce