search

mozilla / persona-gmail-bridge

An experiment in building a minimal identity bridge for Gmail
Mozilla Public License 2.0
11 stars 6 forks source link

Hook up sideshow to Google's OAuth2 endpoint instead of OpenID endpoint. #114

Closed shane-tomlinson closed 9 years ago

shane-tomlinson commented 11 years ago

@callahad, @seanmonstar - I am issuing a tentative PR to start to get feedback.

seanmonstar commented 11 years ago

Is there a way we can keep it as much OAuth instead of Google as possible? Perhaps we can use this for Hotmail as well?

seanmonstar commented 11 years ago

Also, excellent! woo!

shane-tomlinson commented 11 years ago

@seanmonstar - all of the oauth stuff is contained within google.js, so we should, in theory, be able to make sideshow.js the basis for just about any node based IdP.

seanmonstar commented 11 years ago

@shane-tomlinson this looks hawt! I wanna merge it! But it claims merge conflicts. Do you have awsbox with this working that we can point dev at? Excite!

seanmonstar commented 11 years ago

Bump?

shane-tomlinson commented 11 years ago

@seanmonstar - rebased, setting up ephemeral instances now. Let's figure out what we need to do to merge this...

shane-tomlinson commented 11 years ago

@seanmonstar - ephemeral instances are: google-oauth.personatest.org and google-oauth-idp.personatest.org

shane-tomlinson commented 11 years ago

@seanmonstar, @callahad - before merge, we need to copy config.json.example to config.json as well as get some google creds to place into config.example - see https://github.com/shane-tomlinson/browserid-sideshow/commit/f587b1b9d50d0a7fabb944a5d317f4f5c45c7596#diff-12ef3ed9fd13e4ccf3bd7dc3701a5240R3

seanmonstar commented 11 years ago

@shane-tomlinson omg it's beautiful! it just works!

callahad commented 11 years ago

Reads great, but I haven't tested it extensively.

I'm going to try to nuke the config.example.json and stick with our documentation + aborting if things are unset / improperly set approach, if that's OK?

Lastly, there seems to be a lot of abstraction in lib/oauth.js and lib/google.js that I want to re-read a few times before hitting the green button. :)

shane-tomlinson commented 11 years ago

I'm going to try to nuke the config.example.json and stick with our documentation + aborting if things are unset / improperly set approach, if that's OK?

@callahad - where are things set to begin with?

callahad commented 11 years ago

@shane-tomlinson We look at CONFIG_FILES in the environment for paths to json documents that hold settings. Most individual settings can be independently set via environment variables, like SESSION_DURATION.

shane-tomlinson commented 11 years ago

@callahad - got it, that's a good solution.

shane-tomlinson commented 11 years ago

@callahad, @seanmonstar - What do we have to do to merge this? Remove things, change things, I don't mind.

shane-tomlinson commented 11 years ago

config.json.example is removed.

seanmonstar commented 11 years ago

@shane-tomlinson thanks. i'd love to merge, only thing stopping me is local testing. The README hasn't been changed, but I'm sure there's an additional step to setup the oauth. Either that, or are we able to put a default oauth token and secret in the config.js safely?

shane-tomlinson commented 11 years ago

@seanmonstar - let's talk about this on Monday!

seanmonstar commented 11 years ago

@shane-tomlinson so lets talk!

mozfreddyb commented 10 years ago

Any news on this?

groovecoder commented 9 years ago

Bump. Is it worth resurrecting this code? MDN has 50k gmail Persona users who we need to migrate away from OpenID to OAuth.

shane-tomlinson commented 9 years ago

Closing in favor of #126