search

mozilla / persona-gmail-bridge

An experiment in building a minimal identity bridge for Gmail
Mozilla Public License 2.0
12 stars 6 forks source link

Backport spec file fix #121

Closed gene1wood closed 9 years ago

gene1wood commented 10 years ago

Since we never ended up using the two commits on October 3rd, the following commit https://github.com/mozilla/persona-gmail-bridge/commit/404ae2425ca208d2047b3403843ef1e4446bb230 which we need is not available. Please backport https://github.com/mozilla/persona-gmail-bridge/commit/404ae2425ca208d2047b3403843ef1e4446bb230 on top of https://github.com/mozilla/persona-gmail-bridge/commit/1a768a8e17fd57ba28fbffb5310dfc7206577138 and create an rpm for our use. Currently we can only install persona-gmail-bridge with the security fixed nodejs manually with an rpm -ivh --nodeps

gene1wood commented 10 years ago

I may be mistaken. The current package in production has a hash of de46b0d ( browserid-bridge-gmail-0.9.6-0.1.20130926SHAde46b0dR118029.el6.x86_64.rpm ) which appears to have been built by @callahad based on his code in Bug 920030 and released in Bug 920260.

I believe we need to get that code that @callahad has committed into the public repo, then apply the https://github.com/mozilla/persona-gmail-bridge/commit/404ae2425ca208d2047b3403843ef1e4446bb230 commit to it and build and RPM from that.

callahad commented 9 years ago

Closing as obsolete

gene1wood commented 9 years ago

Ya, commit 01870601a8924af4efad9e601523cea7129dcd61 shows that we're looking at a new version of nodejs such that this issue not longer applies. Thanks @callahad