strings ready for train-2013.05.29

[ozten]

Howdy @mathjazz

New strings are ready for the train-2013.05.29 release.

Note: The strings are only on the train-2013.05.29 branch, not master.

/CC @seanmonstar @callahad

[mathjazz]

@ozten, how do I extract & merge strings? Do we have a README?

I'm getting this error:

maggie:browserid-bigtent mathjazz$ ./scripts/extract_pot.sh { [Error: Command failed: /Users/mathjazz/Mozilla/l10n/browserid-bigtent/node_modules/i18n-abide/node_modules/jsxgettext/lib/jsxgettext.js:48 return source.slice(0, range[1]).split('\n').length; ^ TypeError: Cannot read property '1' of undefined at lineFromRange (/Users/mathjazz/Mozilla/l10n/browserid-bigtent/node_modules/i18n-abide/node_modules/jsxgettext/lib/jsxgettext.js:48:35) at /Users/mathjazz/Mozilla/l10n/browserid-bigtent/node_modules/i18n-abide/node_modules/jsxgettext/lib/jsxgettext.js:55:27 at Array.forEach (native) at findComments (/Users/mathjazz/Mozilla/l10n/browserid-bigtent/node_modules/i18n-abide/node_modules/jsxgettext/lib/jsxgettext.js:54:16) at Object.traverse.enter (/Users/mathjazz/Mozilla/l10n/browserid-bigtent/node_modules/i18n-abide/node_modules/jsxgettext/lib/jsxgettext.js:39:26) at traverse (/Users/mathjazz/Mozilla/l10n/browserid-bigtent/node_modules/i18n-abide/node_modules/jsxgettext/node_modules/escodegen/escodegen.js:2041:35) at /Users/mathjazz/Mozilla/l10n/browserid-bigtent/node_modules/i18n-abide/node_modules/jsxgettext/lib/jsxgettext.js:29:5 at Array.forEach (native) at Object.gen as generate at gen (/Users/mathjazz/Mozilla/l10n/browserid-bigtent/node_modules/i18n-abide/node_modules/jsxgettext/lib/cli.js:78:25) ] killed: false, code: 8, signal: null }

[ozten]

Sorry about that. I'm looking into this.

[ozten]

Filed zaach/jsxgettext/issues/18

We have two options: 1) Wait for a fix from our new i18n setup 2) Use gettext tools to extract the strings

[mathjazz]

When is the l10n deadline?

[ozten]

This is a production hotfix, which has been very slow to ship. We don't have a solid deadline.

The production bug is for Yahoo.com users (not other countries) so it is probably okay if we ship an English only production hotfix and then later ship localized strings in a follow up.

What do you think?

[mathjazz]

Yes, I'm okay with shipping the hotfix first and we can follow up with localized strings later.

[ozten]

@mathjazz - Can you try this:

npm install
scripts/extract_pot.sh

This should pickup the latest jsxgettext, which should work now, thanks to @zaach's awesomeness.

[mathjazz]

Thanks, but now it throws another error:

maggie:browserid-bigtent mathjazz$ ./scripts/extract_pot.sh My Path is /Users/mathjazz/Mozilla/l10n/browserid-bigtent/node_modules/i18n-abide/bin /Users/mathjazz/Mozilla/l10n/browserid-bigtent/node_modules/i18n-abide/node_modules/.bin/jsxgettext

/Users/mathjazz/Mozilla/l10n/browserid-bigtent/node_modules/i18n-abide/node_modules/jsxgettext/lib/jsxgettext.js:29 traverse(ast, { ^ TypeError: undefined is not a function at /Users/mathjazz/Mozilla/l10n/browserid-bigtent/node_modules/i18n-abide/node_modules/jsxgettext/lib/jsxgettext.js:29:5 at Array.forEach (native) at Object.gen as generate at gen (/Users/mathjazz/Mozilla/l10n/browserid-bigtent/node_modules/i18n-abide/node_modules/jsxgettext/lib/cli.js:78:25) at main (/Users/mathjazz/Mozilla/l10n/browserid-bigtent/node_modules/i18n-abide/node_modules/jsxgettext/lib/cli.js:69:5) at Object. (/Users/mathjazz/Mozilla/l10n/browserid-bigtent/node_modules/i18n-abide/node_modules/jsxgettext/lib/cli.js:87:1) at Module._compile (module.js:456:26) at Object.Module._extensions..js (module.js:474:10) at Module.load (module.js:356:32) at Function.Module._load (module.js:312:12)

[zaach]

Is the npm install picking up the latest jsgettext? Perhaps try npm install jsgettext@0.0.6 to make sure.

[ozten]

VIA IRC

@mathjazz: ozten: string in Verbatim and SVN, localizers notified

Thanks, you rule!

[zaach]

What was the fix? It looked like i18nabide was still using an older jsxgettext.