search

mozilla / persona

Persona is a secure, distributed, and easy to use identification system.
https://login.persona.org
Other
1.83k stars 265 forks source link

b2g: closing nativeUI does not cause sign in button to be enabled on mfb.com #3377

Closed edwindotcom closed 11 years ago

edwindotcom commented 11 years ago
  1. goto dev.myfavoritebeer.org
  2. click on sign in button
  3. click 'X' to cancel out of native UI

result: sign in button is disabled and greyed out expected: it should be enabled and not greyed out

jedp commented 11 years ago

The dialog subscribes to window.close events, and sends a close command when it receives one. But there are no window.close events on b2g. So it would appear the solution will require some work both on the platform side and in the dialog.

Note that an RP using the observer API will receive the cancel event and have its oncancel callback invoked if someone closes the trusted UI. So this issue affects specifically non-observer RPs.

jedp commented 11 years ago

Actually, the way we implemented get in the native api looks like this actually should work. @ozten and I are investigating now.

jedp commented 11 years ago

I think I see what i did wrong with the native get cancel.

jedp commented 11 years ago

Sorry I didn't close sooner. This has been fixed.