mozilla / persona

Persona is a secure, distributed, and easy to use identification system.
https://login.persona.org
Other
1.83k stars 265 forks source link

Persona dialog blank on MSIE 11 on Windows 8.1 #3593

Closed jedp closed 11 years ago

jedp commented 11 years ago

Robert Kaiser (KaiRo on moz IRC) reports that "Persona doesn't work on MSIE 11 on Win 8.1"

He explained on the #planning channel on Jun 27:

[16:11:06] <KaiRo>   jedp: the sign in popup comes up completely empty, the arrow design is there, but no textbox for filling in an email address - in the end, I guess someone will need to get an image from http://windows.microsoft.com/en-us/windows-8/preview-download and test directly with that browser
[16:12:01] <KaiRo>   jedp: of course, we can't be sure if they'll ship with that UA or if what breaks Persona is a bug on their side
[16:12:49] <KaiRo>   jedp: oh, and I turned off any kind of exception lists or anything they might automatically download - I installed all updates but manually
[16:13:10] <jedp>    KaiRo thanks for the details.  I'll file an issue.
[16:13:29] <KaiRo>   jedp: the latter is just in case they might send different UAs to different sites based on such a downloaded list
jedp commented 11 years ago

Addendum, from KaiRo:

also, I see that those news sites about the "leaked UA string" from a few days ago say "Mozilla/5.0 (IE 11.0; Windows NT 6.3; Trident/7.0; .NET4.0E; .NET4.0C; rv:11.0) like Gecko" while what I see in this Win8.1 preview build is "Mozilla/5.0 (Windows NT 6.3; WOW64; Trident/7.0; rv:11.0) like Gecko" (the missing "IE 11.0" in the latter is significant)

shane-tomlinson commented 11 years ago

I am able to reproduce on dev, but not locally using Windows 8.1 IE11 Metro. Since these are development versions of Windows and IE, we will keep track of this and raise priority as the time for release gets nearer.

This does not reproduce on Windows 8/IE10.

callahad commented 11 years ago

Just a quick note, if we're relying on detecting IE or anything, that may be causing the breakage, since IE11 removes references to "IE" in its UA string: http://www.nczonline.net/blog/2013/07/02/internet-explorer-11-dont-call-me-ie/

shane-tomlinson commented 11 years ago

@callahad - could be - WinChan is the only place where we do UA sniffing for IE.

vladikoff commented 11 years ago

Testing in the 'Metro' version of IE via 123done.org

vladikoff commented 11 years ago

Here's a screenshot form the desktop version:

As you can see in the styles inspector #authentication_form is still 'display: none', If i uncheck that, i can see: .

vladikoff commented 11 years ago

A bit of good news, sign in from login.persona.org works perfectly in both modes!

image

callahad commented 11 years ago

Using Windows 8.1 Enterprise on a Surface Pro with IE 11.0.9600.16384.

  1. First time login (with eyedee.me) works great in Metro mode.
  2. Subsequent logins completely fail (blank dialog) in Metro mode.
  3. First time login completely fails (blank dialog) in Desktop mode.

We know IE 11 / Win 8.1 is coming soon. What's the status of our fix so we don't have to scramble like we did for iOS 7?

callahad commented 11 years ago

RTM bits are available on MSDN. Bumping this to 5-star to avoid breaking in 1-2 weeks when IE 11 gets released and we're all at the Summit.

shane-tomlinson commented 11 years ago

There are (at least) two problems in the version of Windows 8.1 available on modern.ie

1) WinChan has not been correctly updated to browser sniff the new IE11 UA string, causing the postMessage to fail and the dialog to load no content. 2) The dialog window loses it's reference to window.opener after redirecting to the IdP

The second is reported fixed by @callahad using a Surface tablet.

See work started https://github.com/shane-tomlinson/browserid/compare/ie11

ryanseys commented 11 years ago

No excuses not to have an IE (6/7/8/9/10/11) VM lying around when Microsoft is giving them out for free!

http://www.modern.ie/en-us/virtualization-tools#downloads

shane-tomlinson commented 11 years ago

@ryanseys - I have IE6, 7, 8, 9, 10, 11 in Windows XP, Windows 7, Windows 8 and Windows 8.1 in VMs.

An issue for us is that the Windows 8.1 IE11 available on modern.ie is pre-release and does not act the same as RTM in some cases.