search

mozilla / persona

Persona is a secure, distributed, and easy to use identification system.
https://login.persona.org
Other
1.83k stars 265 forks source link

Placeholder text missing on focused fields in IE #4116

Open ryanfeeley opened 10 years ago

ryanfeeley commented 10 years ago

Current (in IE, unsure, witnessed in usertesting.com video)

missing-email-hint

Proposed (and current in Firefox) showing-email-hint

seanmonstar commented 10 years ago

IE didn't get placeholder support until version 10. So 8 and 9 won't have one.

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input On Apr 8, 2014 3:06 PM, "Ryan Feeley" notifications@github.com wrote:

Current (in IE, unsure, witnessed in usertesting.com video)

[image: missing-email-hint]https://cloud.githubusercontent.com/assets/68213/2649892/d0eaaff0-bf68-11e3-82f7-2065c8c889e0.png

Proposed (and current in Firefox) [image: showing-email-hint]https://cloud.githubusercontent.com/assets/68213/2649899/e78356cc-bf68-11e3-81fe-6b6e6cdc8429.png

— Reply to this email directly or view it on GitHubhttps://github.com/mozilla/persona/issues/4116 .

callahad commented 10 years ago

Marking as good first bug. We should have some sort of fallback for placeholder text in IE 8 and 9. MDN suggests http://webdesignerwall.com/tutorials/cross-browser-html5-placeholder-text

Otherwise, Persona's not totally intelligible: "Sign into example.com with..." "with what?"

jaredhirsch commented 10 years ago

if anyone wants this as a good first bug, ping me here and I'll provide neckbeard-level guidance on fixing without adding big libraries to the codebase :neckbeard:

pa5tabear commented 10 years ago

Is this bug still an issue? I'm curious if it's something I'd be able to help solve. I haven't contributed to open source before and am looking for somewhere to start.

jleclanche commented 10 years ago

Would it be reasonable to add a label "Email address:" which is only visible on ie9-? It sounds easier and incidentally would probably be more appropriate for eg. tts readers.

callahad commented 10 years ago

Looks like this polyfill might be a good place to start: https://github.com/UmbraEngineering/Placeholder

I'm inclined to favor polyfills over hiding / showing text so that we don't have to special-case our layouts on IE8/9.

timmarinin commented 10 years ago

@6a68 I want to jump in, if it's still an issue and nobody tackles it. @pa5tabear, how is it going?

sumitbinnani commented 9 years ago

@callahad @6a68 @pa5tabear @marinintim Is anyone working on it? If not, I would like to contribute :-)

shane-tomlinson commented 9 years ago

Hi @sumitbinnani - We have largely wound down development of Persona in favor of Firefox Accounts. I would be happy to mentor you through a bug over there.

sumitbinnani commented 9 years ago

@shane-tomlinson Sure! I would be happy to contribute. Will quickly go through the Firefox Project meanwhile.