Closed hemanth closed 54 years ago
@hemanth, thanks for the PR!
Not sure what this means in Travis, but it looks like we'll need to redo the lockdown.json file with the new dependencies and check that in as well.
Random error from Travis (which is consistent with me trying to download https://github.com/cloudhead/vows/tarball/0 manually):
npm ERR! fetch failed https://github.com/cloudhead/vows/tarball/0
npm ERR! Error: 404 Not Found
npm ERR! at WriteStream.<anonymous> (/home/travis/.nvm/v0.10.31/lib/node_modules/npm/lib/utils/fetch.js:58:12)
npm ERR! at WriteStream.emit (events.js:117:20)
npm ERR! at evalmachine.<anonymous>:1609:14
npm ERR! at /home/travis/.nvm/v0.10.31/lib/node_modules/npm/node_modules/graceful-fs/graceful-fs.js:102:5
npm ERR! at Object.oncomplete (evalmachine.<anonymous>:107:15)
Also, re: express dependency... Does it actually work if we jump from express@2.5.0 to express@4.8.5 directly without any other code changes? I thought there were a lot of tweaks in middlewares and packages and APIs between migrating from 3.x and 4.x that we'd need to change code for.
- "express": "2.5.0",
+ "express": "4.8.5",
@pdehaan Nice catch on express, yes that won't work and migration cloud be taken as a separate task?
Will rollback the version and look into the lockdown.json
as well.
@hemanth Yeah, I think express could definitely be broken out into a separate bug (if there isn't already one) and somebody else can port it over to 3.16.x or 4.8.x — or whatever the latest in each major version is.
@pdehaan I'm facing the same on my localhost as well:
npm ERR! fetch failed https://github.com/cloudhead/vows/tarball/0
Whoops, the mass-closing script misfired. Reopening. Will review in the next day or two.
As per the request.