Allow SVG siteLogos to be specified as data: URIs

mozilla / persona

Persona is a secure, distributed, and easy to use identification system.

https://login.persona.org

Other

1.83k stars 265 forks source link

Closed callahad closed 10 years ago

callahad commented 10 years ago

The only legitimate MIME type for SVGs is "image/svg+xml", but our whitelist contained "image/svg" instead.

As a result, data-URI encoded SVGs were not allowed as the siteLogo.

callahad commented 10 years ago

Tests pass locally. Travis is just acting up (#4179).

Manual verification also looks good.

@Osmose or @6a68, could I get a review?

Osmose commented 10 years ago

Code looks good, r+. Logic for the change makes sense too.

If you expected me to run this code YOU'RE OUTTA YOUR MIND and should let me know to run the code.

callahad commented 10 years ago

self-merging into future

callahad commented 10 years ago