search

mozilla / persona

Persona is a secure, distributed, and easy to use identification system.
https://login.persona.org
Other
1.83k stars 265 forks source link

Fixes #4179. tests/stalled-mysql-test.js failing. #4204

Closed abendigo closed 10 years ago

abendigo commented 10 years ago

Bump up the version of the temp module.

callahad commented 10 years ago

Could you please run ./node_modules/.bin/lockdown-relock to regenerate the lockdown.json? Otherwise, Lockdown will be sad.

abendigo commented 10 years ago

When I run that, it make a lot more changes than I am expecting to lockdown.json

callahad commented 10 years ago

Huh, so it does. It shouldn't.

Let me try this locally...

callahad commented 10 years ago

I'll be damned. Works here. Works on Travis. I'll relock and manually merge.

I'm facepalming so hard right now -- saw the regression in Node 0.10.30 and it completely blinded me to other possible causes. THANK YOU! :beers:

abendigo commented 10 years ago

No worries. I am hoping this wont be my only contribution to this project.

callahad commented 10 years ago

Likewise :) I'm going to close this and merge in #4205, which includes a working relock.

I have to drop offline for a bit, but I'll merge as soon as I get back.

Normally I'd be curious about why your lockdown wasn't hashing things on relock, but instead, I'd like to just move to NPM's built-in shrinkwrap (#4184).

If you want to do more NPM plumbing work, that could be good :)