search

mozilla / personas-plus

Personas Plus extension for Firefox
https://addons.mozilla.org/addon/personas-plus/
Mozilla Public License 2.0
8 stars 11 forks source link

PP does not load header image #107

Closed cellarir closed 6 years ago

cellarir commented 6 years ago

I have used PP with a custom theme in FireFox for years. Even with the new Quantum FF (ver 61), the custom theme I created and saved is still displayed, but I cannot find it in the custom or installed themes lists - or even in the FF profile folder in Users >...>mozilla > firefox. When I try to create a new custom theme in either Firefox or Waterfox, when I browse to a 3000x200 px file for the header image, and click on it, it does not appear to be loaded and I can never "Set" the theme or even cancel out of the custom theme creation window. Is the anyway to create new custom themes in PP? Why does my old theme appear in FF but is not listed?

wagnerand commented 6 years ago

I can't reproduce the behavior on my Firefox 61. Custom themes apply just fine. Can you please provide detailed instructions to reproduce the image?

The list of recent custom themes is unfortunately not implemented currently.

cellarir commented 6 years ago

I got it to work on one computer. What is confusing is that I used to be able to identify the code by name in the profile folder, but it’s not there anymore. I can’t even name the custom theme.

From: Andreas Wagner notifications@github.com Sent: August 2, 2018 02:25 To: mozilla/personas-plus personas-plus@noreply.github.com Cc: cellarir rac@cellarius.net; Author author@noreply.github.com Subject: Re: [mozilla/personas-plus] PP does not load header image (#107)

I can't reproduce the behavior on my Firefox 61. Custom themes apply just fine. Can you please provide detailed instructions to reproduce the image?

The list of recent custom themes is unfortunately not implemented currently.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mozilla/personas-plus/issues/107#issuecomment-409864188 , or mute the thread https://github.com/notifications/unsubscribe-auth/AoESUKTedQE8y4jgSXHDnpjEwDQ2Y1Zeks5uMsVOgaJpZM4VrWmX . https://github.com/notifications/beacon/AoESUH99kmvSgfUvbnhzTwIE3Kzx5xaLks5uMsVOgaJpZM4VrWmX.gif

wagnerand commented 6 years ago

Yes, it's stored differently now, since the new architecture doesn't have access to the filesystem.