search

mozilla / personas-plus

Personas Plus extension for Firefox
https://addons.mozilla.org/addon/personas-plus/
Mozilla Public License 2.0
7 stars 11 forks source link

Personas Plus custom themes do not work #113

Open Moltresrider opened 4 years ago

Moltresrider commented 4 years ago

I opened Firefox today just to find that my custom theme is missing replaced with a completely white blank header and black for text.

I head into Personas Plus settings and attempt to reapply the theme. However, no matter how many times I reselect the header image and choose colors, the custom Firefox theme does NOT apply, it is still completely blank

Personas Plus version 2.0.1

Firefox 70.0.0 (64-bit)

caitmuenster commented 4 years ago

Hi @Moltresrider, thanks for reaching out! In the Firefox 70 release, some internal code was changed that affected theme headers. Additionally, Personas Plus was retired last year.

If you remember what the theme looked like, you should be able to recreate it using Firefox Color, which is compatible with Firefox 70+.

I am really sorry for the inconvenience!

jakebesworth commented 4 years ago

Confirmed this is an issue with v70. Persona Plus "custom theme button" is broken now.

With Firefox Color you are able to reproduce the theme 1:1 but it requires a bit of tweaking as the way Firefox Color balances the transparency, and sections is slightly different than persona plus.

LeeBinder commented 3 years ago

@Moltresrider or @jakebesworth : would you be so kind and attach your latest compile of your Personas Plus xpi? I'm debugging an older version of Thunderbird which has issues with P+ v.1.8.3 (but also with the newer kinds of themes) and I can't find an xpi of v.2.0.2. Thank you.

jakebesworth commented 3 years ago

@LeeBinder this was over a year ago. I would suggest switching to Firefox Color. You can find the code here though: https://github.com/mozilla/personas-plus

LeeBinder commented 3 years ago

Thanks, Jake, for getting back with me so quickly.

I would suggest switching to Firefox Color.

Color themes don't work correctly in Thunderbird Legacy 52.9.1 in macOS Big Sur. Even the default theme fails.

You can find the code here though: https://github.com/mozilla/personas-plus

I know, but I don't have any idea how to package/ compile that into an .xpi Extension.

jakebesworth commented 3 years ago

@LeeBinder I've added you to a private repo with the xpi before it was deprecated.

LeeBinder commented 3 years ago

How nice of you 🥇 ! I already downloaded and installed it but the pane on the left (with the mail accounts and folders) is still blank in Big Sur, so it's not an issue of an outdated Personas Plus Extension. At least one more thing ruled out.

I'll do some more debugging tomorrow - urgently need to catch some sleep now.