Firefox Account Authentication Support

mozilla / personas-plus

Personas Plus extension for Firefox

Mozilla Public License 2.0

8 stars 11 forks source link

Closed derinb closed 8 years ago

derinb commented 8 years ago

Andreas, I added check for Firefox Account authentication and disabled cookie-changed observer again.

Can you confirm it is working with the latest commit with a fresh profile?

wagnerand commented 8 years ago

I haven't tested this, but it looks good to me. Can you please cleanup the cookie-changed observer and squash the commits?

derinb commented 8 years ago

Or you can close this PR and I will upload only Authenticate Check with a proper PR name?

I have tested, it works with new profile and Firefox Accounts.

wagnerand commented 8 years ago

You can update the PR title. If not, I can. But since it's yours, you should be able to.

derinb commented 8 years ago

I just rebased but did not squash because there was 1 commit left. Hope it is OK.

wagnerand commented 8 years ago

Again, Can you please cleanup the cookie-changed observer...

There is no need to have dead code around. Cleaning up is a very important thing in such an old code base. It would be cool if we did more of it!

derinb commented 8 years ago

Andreas, lets clean up the old code after we release restartless version and we make sure the login and custom personas bugs are fixed for all users.

I want to make the restartless transition as much painless as possible. I can remove the old code with another update XPI.

wagnerand commented 8 years ago

Can you please use more descriptive commit titles? For example

Add support for FxA login or something.

You can change the commit title with just git commit --amend. Make sure nothing is staged, otherwise it will get amended to the commit as well.

derinb commented 8 years ago

Done.

derinb commented 8 years ago

Andreas, can you approve this so I can send another PR?

wagnerand commented 8 years ago

You can send PRs any time.