Closed derinb closed 8 years ago
derinb
commented
8 years ago I see new release is already approved. Andreas, this is very urgent. Because of the data:uri bug, restart version of PP saves personas in preferences with data:uris for headerURL and footerURL, although the custom personas do not work. Because new version uses resource://uri, if there are data:uris in preferences, it is replaced with resource:uris
wagnerand
commented
8 years ago Please file a bug for this PR with detailed steps to reproduce the issue to make sure this patch fixes it.
derinb
commented
8 years ago wagnerand
commented
8 years ago It's probably because you are mixing tabs and spaces. Text editors have to interpret how many space one tab represents. So, for some editors it shows correct but that's just coincidental.
If that file has formatting errors, let's fix that in another patch, but let's not make things worse.
Am Donnerstag, 9. Juni 2016 schrieb derinb :
Related bug
32 https://github.com/mozilla/personas-plus/issues/32
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mozilla/personas-plus/pull/31#issuecomment-225012973, or mute the thread https://github.com/notifications/unsubscribe/AA1TKtVYDdlkVKWxISOJvSS-Q50QbHU2ks5qKHRggaJpZM4IyGDB .
derinb
commented
8 years ago No, indeed I did not touch those below 2 lines. They got flagged themselves automatically. I tried to reset them but could not succeed. So at least made sure they have the same indent in Github Desktop but this time Github.com cries.
I use Sublime Text and I made sure Spaces 4 is selected. Those two lines were already in a bad format. Maybe there were /r
The whole file contains many format issues. So as you suggested I did not prettified it not to make things complex when reviewing.
Custom Persona Data:URI Bug Fix