mozilla / personas-plus

Personas Plus extension for Firefox
https://addons.mozilla.org/addon/personas-plus/
Mozilla Public License 2.0
8 stars 11 forks source link

Reinstalling the Personas Plus add-on will cause display issues in the menu #38

Closed cosminbadescuSV closed 8 years ago

cosminbadescuSV commented 8 years ago

Steps to reproduce:

1.Install the Personas Plus version 1.8.0b1 add-on 2.Verify the add-on menu 3.Uninstall the add-on then install it again.

Expected results: The add-on menu is displayed without any issues.

Actual results: The add-on menu is displayed with issues.

Note/Issues: Verified on FF48.0b7(Win 7 64-bit) This issue is reproducing in AMO production server This issue is reproducing with e10s enabled and disabled

Here is a video: menu

wagnerand commented 8 years ago

Thanks for the report!

Adding @derinb.

wagnerand commented 8 years ago

We should fix this for 1.8.

derinb commented 8 years ago

This should be fixed by PR https://github.com/mozilla/personas-plus/pull/44

Because previous add-on was Restart, remnant of onQuitApplication caused issue for Restartless add-on.

Please test it on a fresh profile.

cosminbadescuSV commented 8 years ago

I tried with 1.8.0b3. here are the results: -1.8.0b3. e10s enabled: menue10senabled

-1.8.0b3. e10s disabled: menue10sdisabled

wagnerand commented 8 years ago

Looks like this is working fine now. Thank you!