Restart is required after first install

[cosminbadescuSV]

Steps to reproduce:

1.Install the Personas Plus version 1.8.0b1 add-on

Expected results: No restart is required.

Actual results: A restart is required.

Note/Issues: Verified on FF48.0b7(Win 7 64-bit) This issue is reproducing intermittently in AMO production server

Here is a video:

[wagnerand]

Is this with e10s enabled?

[cosminbadescuSV]

The e10s was not enabled

[wagnerand]

Thanks.

Adding @derinb. Can you look into that, please? It blocks the release of 1.8. Thanks!

[wagnerand]

@cosminbadescuSV I wonder whether there is anything special about your installation there. I have seen screencasts for other bugs here where it is installed without showing the 'needs a restart' doorhanger.

[cosminbadescuSV]

This issue is reproducing only at first install on a new profile.

[derinb]

Cant produce it on my side.

You may have configuration issues on your local comp. Could you please try in another profile or another computer, if possible?

@wagnerand you can also be able to install on a fresh profile without restart, right?

[derinb]

Just a note, if you install Restartless version over AMO's current version of PP, it requires restart.

But on a fresh profile and for first install, it does not require Restart.

[cosminbadescuSV]

Installing PP on a new profile: http://screencast.com/t/tu1UupGL7FGm

[derinb]

I see. Really strange.

Could you please install local XPI file from your desktop?

BTW, you need to install 1.8.0b2 from the latest commit.

Should @wagnerand compile for you?

@madalincm does the XPI require restart for you?

[wagnerand]

This will be fixed in the next beta, as the milestone says.

@derinb are you going to fix more bugs before Monday? I don't want to create a beta for each patch. It's fine to fix a couple of them before releasing a new beta. The QA team can retest and close the bugs if they are fixed.

[wagnerand]

Wait, is https://github.com/mozilla/personas-plus/pull/44 supossed to fix this issue, @derinb?

[derinb]

Nope, 44 is for https://github.com/mozilla/personas-plus/issues/38

This is I think a configuration or AMO issue. Or maybe electrolysis flag in install.rdf may fix it.

I think you should compile XPI for them to test. electrolysis flag may fix this bug too, though my versions installs on Nightly Firefox without restart although I did not add electrolysis flag in install.rdf

[wagnerand]

How can this be an AMO issue? This has nothing to do with AMO. As e10s was disabled during testing, it also has nothing to do with e10s.

Can you please give this another look and try to come up with a patch before I release a new beta? Thanks.

[derinb]

Andreas, <em:bootstrap>true</em:bootstrap> is already placed in install.rdf. There is nothing that may require add-on for Restart.

I am not sure about this issue and I can not produce the issue. That is why I recommended @cosminbadescuSV to test another computer.

[wagnerand]

I did some more digging.

@cosminbadescuSV In that profile, can you go to about:support and tell us what Multiprocess Windows shows?

[wagnerand]

I strongly suspect e10s was enabled afterall. I'm going to close this. Please try again in 1.8.0b3.

[cosminbadescuSV]

I tried with 1.8.0b3. here are the results: -1.8.0b3. e10s enabled:

-1.8.0b3. e10s disabled:

[wagnerand]

@cosminbadescuSV would you mind trying the same in aurora as well? If have been told that beta is a special case where we require add-ons to be on a special "allow list".

[cosminbadescuSV]

Of course :smile: here are the videos: -1.8.0b3. e10s enabled:

-1.8.0b3. e10s disabled:

[wagnerand]

Looks good,thank you!