Undo Fix for First Install

mozilla / personas-plus

Personas Plus extension for Firefox

https://addons.mozilla.org/addon/personas-plus/

Mozilla Public License 2.0

8 stars 11 forks source link

Undo Fix for First Install #46

Closed derinb closed 8 years ago

derinb commented 8 years ago

Fix for After pressing “Undo” button, the theme is not removed Bug

wagnerand commented 8 years ago

Can you please in your PR message use "Fixes #ISSUE-NUMBER" so issues automatically get closed when the PR lands? Thanks!

wagnerand commented 8 years ago

Looks good, thanks!

derinb commented 8 years ago

Does not QA need to give confirmation before accepting PR?

wagnerand commented 8 years ago

No the process is a bit different. Someone writes a patch, and after a reviewer approved the code and it lands, the issue gets closed automatically. QA then looks at the closed bugs (that's why I added milestones) and verifies (by testing again) whether they really have been fixed. If not, they get reopened.