search

mozilla / personas-plus

Personas Plus extension for Firefox
https://addons.mozilla.org/addon/personas-plus/
Mozilla Public License 2.0
7 stars 11 forks source link

Custom persona with wrong image size is applied anyway. #72

Closed wagnerand closed 8 years ago

wagnerand commented 8 years ago

Just try to apply a custom persona with an invalid image size. The warning dialog appears but the persona is applied anyway.

derinb commented 8 years ago

Confirmed. Because of making sure dimensions check, I missed the apply. Will fix it now.

wagnerand commented 8 years ago

While you're at it, please remove the unnecessary return statement in the image onload function.