search

mozilla / personas-plus

Personas Plus extension for Firefox
https://addons.mozilla.org/addon/personas-plus/
Mozilla Public License 2.0
8 stars 11 forks source link

Chrome.manifest Support for SeaMonkey #76

Closed derinb closed 8 years ago

derinb commented 8 years ago

chrome.manifest declarations are missing for SeaMonkey. Because of that,

chrome://personas/skin/

does not get registered for SeaMonkey

derinb commented 8 years ago

I just duplicated Firefox entries to create SeaMonkey entries. Some does not make sense. Feel free to suggest please.

wagnerand commented 8 years ago

Please remove the ones that don't make sense. Also, please test your patches before submitting pull requests.

derinb commented 8 years ago

Well, the appversion<3.1b2 entries does not make sense because I suppose it imply the FF version numbers. I am not sure also what they are doing actually?

There are too many operating systems. I cant test patches on FreeBSD and and SunOS. But tests on Windows are OK.

Entries actually make sure skin folder is registered for SeaMonkey. Currently it does theoretically for all OSes.

I can simply remove appversion<3.1b2 entries and make a single entry for Mac. What do you suggest?

wagnerand commented 8 years ago

I'm not familiar enough with Seamonkey to suggest something. I'd rather focus on a great experience in Firefox.

Adding Seamonkey support is fine, but the patch needs to be clean and not interfere with Firefox.

Testing on exotic operating systems is not necessary, but as far as I can tell this patch is not about those. We need to make sure PP works fine on Windows, Mac and Linux, so that's what we should test on.

derinb commented 8 years ago

Hello Andreas,

This PR only includes only SeaMonkey Guid. As you suggested I am making sure Firefox is not affected.

I have tested it on Windows 10 and Mac OS X. Working fine for SeaMonkey. Please accept the PR. I will fix any issues for SeaMonkey if I detect or any SeaMonkey user reports.