search

mozilla / personas-plus

Personas Plus extension for Firefox
https://addons.mozilla.org/addon/personas-plus/
Mozilla Public License 2.0
8 stars 11 forks source link

Theme info bar cannot be dismissed by clicking the "Undo" button after uninstalling Persona Plus #82

Closed wagnerand closed 8 years ago

wagnerand commented 8 years ago

Clones from https://bugzilla.mozilla.org/show_bug.cgi?id=1313673:

Steps to reproduce:

  1. Install attached "Persona Plus" add-on from about:addons
  2. Remove the "Persona Plus"
  3. Click the "Undo" button from the info bar

Expected results: The info bar is dismissed.

Actual results: Nothing happens.

Notes/Issues: Reproducing also if add-on is disabled. Verified on FF49.0.2 using Windows 7 x64 Screencast for this issue: http://screencast.com/t/0SsFZnIVdrMj

/cc @ValentinaPC

ValentinaPC commented 8 years ago

@wagnerand : Where (or how) can I check this to see it is fixed? Thanks!

wagnerand commented 8 years ago

@ValentinaPC Do the STR above not work for you?

ValentinaPC commented 8 years ago

Well, of course they do - I wrote them - but still happening the same - "undo" option is not dismissed. :smile:

wagnerand commented 8 years ago

Oh, ok! 😄

@derinb Can you check this and/or update the STR please?

derinb commented 8 years ago

@wagnerand I think you should compile the latest XPI for Valentina. She is probably testing with the old XPI file.

@ValentinaPC Please let us know if you have the latest XPI from the latest commit.

Thanks

ValentinaPC commented 8 years ago

@derinb : I think I don't, but I'd love to have it. :smile:

wagnerand commented 8 years ago

Ah yes, sorry I didn't think about that.

@ValentinaPC I just uploaded a new beta version: https://addons.mozilla.org/en-US/firefox/addon/personas-plus/

ValentinaPC commented 8 years ago

Verified as fixed using the beta version from above link and FF49.0.2(Win 7 x64) Postfix video: undo

wagnerand commented 8 years ago

Awesome, thank you!