search

mozilla / personas-plus

Personas Plus extension for Firefox
https://addons.mozilla.org/addon/personas-plus/
Mozilla Public License 2.0
8 stars 11 forks source link

Disabling Image Size Restriction #94

Closed derinb closed 7 years ago

derinb commented 7 years ago

Some users do not create themes for AMO submission and want to casually test images for the browsers.

https://addons.mozilla.org/en-US/firefox/addon/personas-plus/reviews/837053/

Disabling the restriction by a preference or even with a preference that can only be accessible via about:config may help for those kind of users.

If it is acceptable, I like to add the preference.

wagnerand commented 7 years ago

A preference for that seems reasonable, but I think it should be disabled by default.

Loading images with unsupported resolutions might result in weird effects and we should be clear that this is not supported.

derinb commented 7 years ago

Sure it will be set to disabled as default to comply AMO.

Is showing a warning prompt necessary when the preference is enabled? Users are already prompted by Image Size prompt, though.

wagnerand commented 7 years ago

I don't think showing a warning prompt is necessary.