search

mozilla / petitions.mozilla.org

Petitions for Mozilla Advocacy
https://petitions.mozilla.org
Mozilla Public License 2.0
1 stars 9 forks source link

[fix bug 1239466] Add page for Data Privacy Day. #111

Closed jpetto closed 8 years ago

jpetto commented 8 years ago

@jbuck - Have a moment for code review? Hoping to get this up on the staging server early tomorrow (2/26) for stakeholders to give final review.

If not, I can ask one of the fine mozilla.org devs to take a look.

Thanks!

jbuck commented 8 years ago

@alicoding @ScottDowne too

ScottDowne commented 8 years ago

Just one comment, but I don't think it should block, otherwise it all looks pretty standard and I hold no strong opinions :)

@jbuck I'm fine with this going on staging.

jpetto commented 8 years ago

Just pushed another commit with some minor-ish changes - biggest being the removal of first/last name fields. If we're good to go, I'll squash the commits.

After squash and merge, how long until the changes are on staging?

jbuck commented 8 years ago

@jpetto r+, can you squash?

jpetto commented 8 years ago

Squashed!