search

mozilla / petitions.mozilla.org

Petitions for Mozilla Advocacy
https://petitions.mozilla.org
Mozilla Public License 2.0
2 stars 9 forks source link

Need more specific errors #20

Closed secretrobotron closed 9 years ago

secretrobotron commented 9 years ago

If your email address is wrong, or if you haven't checked a required checkbox, the error message is the same: "Oops, please complete fields highlighted in red." We should help out a bit more by stating what's wrong.

@lovegushwa @ScottDowne to avoid the clutter of a bunch of simultaneous error messages, does this seem like a good hierarchy?

  1. "please fill in required fields" (highlighted in red — just as they are now)
  2. "your email address is invalid"
  3. "make sure you check the opt in checkbox"

(This is firmly P2.)

lovegushwa commented 9 years ago

@secretrobotron @ScottDowne were just talking errors today. Once you get these in the form's let me know and I'll help tweak.

ScottDowne commented 9 years ago

@secretrobotron I'm not going to worry about changing the actual error message text, as that'll happen when we paste in the translated text. Can you make sure the errors you want are translated though?

I'll ensure we display the messages in the right cases in the correct places.

ScottDowne commented 9 years ago

petition1

I added an error message for country too, because the generic one seemed really out of place under email, and if I moved it under country, it made it look like it wasn't associated with the name fields.

My copy is a placeholder... Need to get proper error messages translated given the above image. Also the first error message can be specific for first and last name.

https://github.com/mozilla/petitions.mozilla.org/pull/28

ScottDowne commented 9 years ago

Landed, moved remaining tasks to #29