search

mozilla / petitions.mozilla.org

Petitions for Mozilla Advocacy
https://petitions.mozilla.org
Mozilla Public License 2.0
2 stars 9 forks source link

Test coverage #22

Open secretrobotron opened 9 years ago

secretrobotron commented 9 years ago

Once we've got the fundamentals set up, this repo should have some test coverage for front end and back end.

@cadecairos did a pretty good job writing test coverage for api.webmaker.org. Any tips? @ScottDowne what should we do for front-end tests?

cadecairos commented 9 years ago

Measure test coverage. I used lab

While not a true measure of the comprehensiveness of your tests, you'll at least be able to tell which code paths need tests written.

Try and keep things as modular as possible, because I let some files get way out of hand, and it becomes pretty unmaintainable, forcing lengthy refactoring work.

ScottDowne commented 9 years ago

For front end, in the end, I want the sign up pages to use react components.

The same react components I have been building for donate. Thus, it would use the same tests. (which don't exist yet for donate)

Donate already has a signup page built with react components. Looks kinda like this: https://github.com/mozilla/donate.mozilla.org/blob/master/components/signup.jsx#L23-L33

It's also using the same privacy policy and email component as the donation forms.

So once these have tests, all these repos win.