mozilla / ping-centre

INACTIVE - http://mzl.la/ghe-archive
Mozilla Public License 2.0
8 stars 10 forks source link

Add fields for better identify onboarding user type #121

Closed gasolin closed 7 years ago

gasolin commented 7 years ago

Related to Bug 1412164 - add new column for onboarding telemetry (client side work), we also need add columns in server side.

for firefox_onboarding_sessions_daily table,

for firefox_onboarding_events_daily table,

And we will add onboarding-icon-click event in firefox_onboarding_events_daily table, but I think it does not require column change

gasolin commented 7 years ago

@ncloudioj could you help on this?

ncloudioj commented 7 years ago

@gasolin Sure, will do.

Also, just a reminder that once we add those new columns to the database, the existing data records will not have values for them (i.e. the value will be null). It might need some extra care when querying the database.

gasolin commented 7 years ago

got it, thanks for the notice

gasolin commented 7 years ago

related client code is landed into nightly https://bugzilla.mozilla.org/show_bug.cgi?id=1412164

gasolin commented 7 years ago

As discussion on slack, this database change might be delayed due to the database scale up, but should be able to catch up before 57 hits the road

ncloudioj commented 7 years ago

@gasolin This is now fixed.