search

mozilla / playdoh

PROJECT DEPRECATED (WAS: "Mozilla's Web application base template. Half Django, half awesomeness, half not good at math.")
BSD 3-Clause "New" or "Revised" License
710 stars 107 forks source link

example app doesn't work out of the box #131

Closed jtratner closed 12 years ago

jtratner commented 12 years ago

Right now, the example app (showing bleach sanitation) doesn't work right out of the box because jingo and jingo_minify aren't installed AND there is no MINIFY_BUNDLE setting initially. While I appreciated the opportunity to debug a mysterious django error message and thereby read the docs for jingo_minify, it was a bit of a downer to not be able to say "oooh, pretty playdoh!" right out of the box ;)

Anyways, I've attached a commit that makes everything run (by removing the js() tag in example_base.html and adding jingo to INSTALLED_APPS).

Also, it would be really helpful to add a line in the Settings Management API part of the docs to say that you should set the settings for the playdoh app in yourapp/settings/base.py and yourapp/settings/local.py, just to give a newcomer a tip in the right direction to finding those things.

peterbe commented 12 years ago

r-

We have abandoned jingo_minify and therefore we shouldn't use js() any more. I was the one who made the switch to django_compressor and in doing so I (thought) replace js() and css() with the new way of doing it. I'm surprised I missed the js() one and I will do something about that.

Regarding the confusion about the settings. What was it that confused you? One thing I can see is that it's not clear that the settings directory is under the "project" directory. It does however become more obvious once you realise you have to rename "project" to "myapp".

peterbe commented 12 years ago

Regarding the jingo needed in INSTALLED_APPS. I don't think that needs to be an installed app. It actually kicks in from being set in TEMPLATE_LOADERS in funfactory.

peterbe commented 12 years ago

I think this is all we need to make playdoh work out-of-the-box https://github.com/mozilla/playdoh/pull/132

jtratner commented 12 years ago

On the settings confusion: I think it was mostly a conceptual mistake: I'd been working with single file "settings.py" settings files for django for quite a while, and (for whatever reason), didn't occur to me that you could make the setting into an elegant package structure instead. In hindsight, had I looked at appname/settings/__init__.py, I probably would have figured it out.