mozilla / playdoh

PROJECT DEPRECATED (WAS: "Mozilla's Web application base template. Half Django, half awesomeness, half not good at math.")
BSD 3-Clause "New" or "Revised" License
709 stars 107 forks source link

upgrade playdoh-lib #172

Closed peterbe closed 10 years ago

peterbe commented 10 years ago

@pmclanahan @Osmose @willkg r?

(playdoh)peterbe@mpb:~/dev/DJANGO/playdoh (upgrade-playdoh-lib *%)$ s
[deprecation warnings suppressed]
>>> import django
>>> django.get_version()
'1.5.6'
>>> import django_browserid
>>> django_browserid.__version__
'0.10.1'
>>>
peterbe commented 10 years ago

ping @pmclanahan @Osmose @willkg

Osmose commented 10 years ago

not it

pmclanahan commented 10 years ago

This pulls in a whole lot of new stuff right? Would you mind adding the git log --oneline output to the commit message?

peterbe commented 10 years ago

Done https://github.com/peterbe/playdoh/commit/8d0df10786ab6370844d09a60f6a7f41d5debfb1

pmclanahan commented 10 years ago

I guess we should also update to Django 1.5.7. We can do that separately though.

peterbe commented 10 years ago

Upgrading Django is a playdoh-lib thing but I guess we should do that too.

pmclanahan commented 10 years ago

I would merge but I've not done any testing. The changes themselves look fine, but I'm concerned that other changes are needed which we might have missed and would trip up someone starring a new project.

Have you done this @peterbe? If we need to merge this soon then I'll trust you on this. Otherwise I think it might be best to take the time to try starting a new project and testing stuff out with new Django.

peterbe commented 10 years ago

Yes I have tested this. I started it and was able to sign in.

peterbe commented 10 years ago

And able to sign out.

pmclanahan commented 10 years ago

works for me. Thanks @peterbe !

pmclanahan commented 10 years ago

Thanks. Nightly crashed when I submitted that last comment. Been very crashy on GH recently.