search

mozilla / playdoh

PROJECT DEPRECATED (WAS: "Mozilla's Web application base template. Half Django, half awesomeness, half not good at math.")
BSD 3-Clause "New" or "Revised" License
709 stars 107 forks source link

Register/Login? #78

Open gkoberger opened 13 years ago

gkoberger commented 13 years ago

One thing that most sites definitely need but playdoh doesn't provide is a way to register / log in. I'm not sure if this really fits in with the "mission" of playdoh, but it would be nice to have a "users" app by default that people could delete if they decided they didn't need it.

I'd be happy to write it, if it seems like it's something we'd want for playdoh.

fwenzel commented 13 years ago

I like the idea, though this is pushing playdoh from barebones platform into the domain of Pinax, a little bit -- mind you, just because something works with playdoh doesn't mean we need to bundle it by default. So if anything, you could write a library -- I wonder if django-registration and others would already do the trick.

Also keep in mind that we're promoting browserid -- it might make more sense to bundle that with playdoh instead. It doesn't completely eliminate the need for all of what you're describing, but almost.

tofumatt commented 13 years ago

Django provides a lot of auth functionality for us and wiring it up to some urls/templates isn't a tonne of work, but I still view this as a fine idea. It fits into the app template of playdoh more than the library nature of funfactory, the way I see it.

What might be quite interesting about this is having flows for multiple auth systems (regular auth, browserid, etc) built into the app template.

I'm on board for this.

Matthew Riley MacPherson | http://tofumatt.com (Sent from mobile)

On 2011-10-22, at 6:45 PM, Gregory Koberger reply@reply.github.com wrote:

One thing that most sites definitely need but playdoh doesn't provide is a way to register / log in. I'm not sure if this really fits in with the "mission" of playdoh, but it would be nice to have a "users" app by default that people could delete if they decided they didn't need it.

I'd be happy to write it, if it seems like it's something we'd want for playdoh.

Reply to this email directly or view it on GitHub: https://github.com/mozilla/playdoh/issues/78

ygjb commented 13 years ago

When you guys have something together please feel free to tag me to do a secreview of it. Having this stuff built in and ready to go would be great!

kumar303 commented 13 years ago

@gkoberger Django already provides a sophisticated backend for user registration and login: https://docs.djangoproject.com/en/dev/topics/auth/

or were you envisioning something different?

gkoberger commented 13 years ago

@kumar303 I'm not saying we should write our own from scratch; just ship with something that works with some of the things we've done (jinja2, csrf modifications, etc). I've seen a number of blog posts from people having trouble getting an auth system set up. It would be nice to have a /users/ app that came with it, that did stuff like registration, login, forgotten password, etc.

Additionally, this would be a good way to push BrowserID, like other people said.

I know that it's a departure from what PlayDoh has been up until now, however I can't shake the feeling that having an example login system ship with PlayDoh would really come in handy. And if someone doesn't want it, it's as easy as deleting the app.

peterbe commented 13 years ago

I wouldn't like to see it in playdoh but if there was a "django-registration mozilla equivalent" in playdoh-lib I would support it.

If you create a standalone app called "playdoh-registration" that contains jinja templates, a authentication form that uses email, and some nifty views. But usually the user profile class is different in every project, so how would you deal with that?

kumar303 commented 13 years ago

Everything in Playdoh is a standalone application (or module/middleware) so, yeah, something like browserid-registraion or whatever would be a good addition and I agree that it should be bundled with Playdoh if it's generic enough. FWIW, I do think all of our csrf mods and security fixes are applied to the default auth system though.

peterbe commented 13 years ago

On that note, I wrote a little helper for django-auth-ldap which makes it easy to plugin with the Mozilla LDAP in django. It's obviously useful for internal sites but is there interest in putting this into playdoh-lib?

fwenzel commented 13 years ago

Peter: Bundling it by default, I'd say no. LDAP is such an enterprisey auth backend that I just don't think it's generic enough for playdoh. But please do add it to the list of libs in the docs.

Osmose commented 12 years ago

Does closing #73 seem good enough to close this issue? It's not quite a users app, but login and logout are now handled in the example app and supported by the included libraries and configuration.