search

mozilla / pluotsorbet

[ARCHIVED] PluotSorbet is a J2ME-compatible virtual machine written in JavaScript.
GNU General Public License v2.0
237 stars 46 forks source link

enable socket tests #141

Closed mykmelez closed 9 years ago

mykmelez commented 10 years ago

We landed support for sockets with tests that are marked as todo because the test page needs tcp-socket permission to access mozTCPSocket, and we can't yet set that permission for the page in SlimerJS. See this conversation about fixes for the problem. Once SlimerJS supports granting tcp-socket to the page, we should enable the tests.

marco-c commented 9 years ago

https://github.com/laurentj/slimerjs/pull/239 should make this feasible

marco-c commented 9 years ago

https://github.com/laurentj/slimerjs/pull/239 has been merged

mykmelez commented 9 years ago

SlimerJS has nightlies: http://download.slimerjs.org/nightlies/

I wonder if there's a way to make Travis use them.

marco-c commented 9 years ago

I think it's possible, there's an old working example here: https://github.com/travis-ci/travis-ci/issues/1290

marco-c commented 9 years ago

Another example is here: https://github.com/mnem/travisci-webgl-test/blob/8d0da4ba51074f9a329c4a61231d83fd961f00b5/.travis.yml

marco-c commented 9 years ago

Other references: https://bugzilla.mozilla.org/show_bug.cgi?id=1091984 https://gist.github.com/muffinresearch/8579845

marco-c commented 9 years ago

While I was doing #1131, I've done this as well (in #1132).