mozilla / pontoon

Mozilla's Localization Platform
https://pontoon.mozilla.org
BSD 3-Clause "New" or "Revised" License
1.45k stars 526 forks source link

When adding a locale to a project config, Pontoon should add that locale #2163

Open bugzilla-to-github opened 5 years ago

bugzilla-to-github commented 5 years ago

This issue was created automatically by a script.

Bug 1539913

Bug Reporter: @Pike CC: @flodolo, @Delphine, @mathjazz

For the Android projects, we'd like to maintain the locale list in l10n.toml.

It'd be nice if Pontoon would detect a new locale in l10n.toml and add it to the project.

This seems much more achievable than reflecting the project edits in pontoon into l10n.toml, in particular with sub-configs having a different locale list.

Not sure if this is in any way related to bug 960291.

bugzilla-to-github commented 5 years ago

Comment Author: @mathjazz

Is there support for read-only locales in project configuration file format? Or how would a PM workflow look for adding a read-only locale to a project?

I think we can wontfix bug #960291 and say "you need to use project configuration files" in order to "auto-detect locales".

bugzilla-to-github commented 5 years ago

Comment Author: @Pike

Good question about read-only locales. We should ask the PMs if it's good enough for a locale to be read-write for a bit before making it read-only explicitly?

I'm leaning towards not having pontoon-specifics like read-only in p-c, we'll need to figure that out, though.

BTW, we just added locales on android-l10n, and the logs looked very weird:

Apr 24 15:52:43 mozilla-pontoon app/worker.1: Syncing translations for project: android-l10n 
Apr 24 15:52:43 mozilla-pontoon app/worker.1: [2019-04-24 15:52:43,839: INFO/Worker-43] Syncing translations for project: android-l10n 
Apr 24 15:52:43 mozilla-pontoon app/worker.1: Pulling changes for project android-l10n started. 
Apr 24 15:52:43 mozilla-pontoon app/worker.1: [2019-04-24 15:52:43,857: INFO/Worker-43] Pulling changes for project android-l10n started. 
Apr 24 15:52:44 mozilla-pontoon app/worker.1: Pulling changes for project android-l10n complete. 
Apr 24 15:52:44 mozilla-pontoon app/worker.1: [2019-04-24 15:52:44,128: INFO/Worker-43] Pulling changes for project android-l10n complete. 
Apr 24 15:52:44 mozilla-pontoon app/worker.1: Retrieving changed files for: /app/media/projects/android-l10n/git@github.com:mozilla-l10n/android-l10n.git:6999533181a1e2c79a045e4f96bfa93d1d9003a4 
Apr 24 15:52:44 mozilla-pontoon app/worker.1: [2019-04-24 15:52:44,156: INFO/Worker-43] Retrieving changed files for: /app/media/projects/android-l10n/git@github.com:mozilla-l10n/android-l10n.git:6999533181a1e2c79a045e4f96bfa93d1d9003a4 
Apr 24 15:52:44 mozilla-pontoon app/worker.1: Changed files in Android L10n repository, all: ['MozillaReality/FirefoxReality/l10n.toml', 'mozilla-mobile/android-components/l10n.toml', 'mozilla-mobile/fenix/l10n.toml'] 
Apr 24 15:52:44 mozilla-pontoon app/worker.1: [2019-04-24 15:52:44,171: INFO/Worker-43] Changed files in Android L10n repository, all: ['MozillaReality/FirefoxReality/l10n.toml', 'mozilla-mobile/android-components/l10n.toml', 'mozilla-mobile/fenix/l10n.toml'] 
Apr 24 15:52:44 mozilla-pontoon app/worker.1: Changed files in Android L10n repository, relevant for enabled locales: {'MozillaReality/FirefoxReality/l10n.toml': [<Locale: Spanish>], 'mozilla-mobile/fenix/l10n.toml': [<Locale: Spanish>], 'mozilla-mobile/android-components/l10n.toml': [<Locale: Spanish>]} 
Apr 24 15:52:44 mozilla-pontoon app/worker.1: [2019-04-24 15:52:44,183: INFO/Worker-43] Changed files in Android L10n repository, relevant for enabled locales: {'MozillaReality/FirefoxReality/l10n.toml': [<Locale: Spanish>], 'mozilla-mobile/fenix/l10n.toml': [<Locale: Spanish>], 'mozilla-mobile/android-components/l10n.toml': [<Locale: Spanish>]} 
Apr 24 15:52:44 mozilla-pontoon app/worker.1: Changed files in Android L10n repository and Pontoon: {'MozillaReality/FirefoxReality/l10n.toml': [<Locale: Spanish>], 'mozilla-mobile/fenix/l10n.toml': [<Locale: Spanish>], 'mozilla-mobile/android-components/l10n.toml': [<Locale: Spanish>]} 
Apr 24 15:52:44 mozilla-pontoon app/worker.1: [2019-04-24 15:52:44,186: INFO/Worker-43] Changed files in Android L10n repository and Pontoon: {'MozillaReality/FirefoxReality/l10n.toml': [<Locale: Spanish>], 'mozilla-mobile/fenix/l10n.toml': [<Locale: Spanish>], 'mozilla-mobile/android-components/l10n.toml': [<Locale: Spanish>]} 
Apr 24 15:52:44 mozilla-pontoon app/worker.1: Changed files in Android L10n repository: [] 
Apr 24 15:52:44 mozilla-pontoon app/worker.1: [2019-04-24 15:52:44,260: INFO/Worker-43] Changed files in Android L10n repository: [] 
Apr 24 15:52:44 mozilla-pontoon app/worker.1: Skipping syncing translations for project android-l10n, none of the locales has anything to sync. 
Apr 24 15:52:44 mozilla-pontoon app/worker.1: [2019-04-24 15:52:44,261: INFO/Worker-43] Skipping syncing translations for project android-l10n, none of the locales has anything to sync. 

Why would a change to a p-c file touch Spanish, and just Spanish?

bugzilla-to-github commented 3 years ago

Comment Author: @mathjazz

Why would a change to a p-c file touch Spanish, and just Spanish?

Seems like we're hitting bug #1608045 here.