mozilla / pontoon

Mozilla's Localization Platform
https://pontoon.mozilla.org
BSD 3-Clause "New" or "Revised" License
1.46k stars 526 forks source link

CSS boilerplate is out of date #2867

Open eemeli opened 1 year ago

eemeli commented 1 year ago

As identified in #2864, our CSS boilerplate is originally from h5bp/html5-boilerplate, but has not been kept updated with the upstream.

It would be good to review the changes that have been applied in the last decade or so, and apply them here.

haastrupea commented 1 year ago

Hi @mathjazz , I am new here. I recently came across Pontoon on OpenSauced. I am done setting up the project on my local machine and I would love to work on this issue as my first of many here.

mathjazz commented 1 year ago

Hi @haastrupea! Happy to hear you'd like to contribute and I'm assigning the issue to you!

haastrupea commented 1 year ago

Great👍

haastrupea commented 1 year ago

I have a question @eemeli and @mathjazz how did you guys find out that the boilerplate.css was from h5bp/html5-boilerplate library?

I have compared the lib older version from around the same time @adngdb made this file, they seem different. I believe he curated the reset, font normalization, and base styling from different sources which he mentioned

Most of these sources have not changed in recent times (I have not noticed any changes, at least for now)

My Suggestions

mathjazz commented 1 year ago

how did you guys find out that the boilerplate.css was from h5bp/html5-boilerplate library?

That's what the comment in the header says: https://github.com/eemeli/pontoon/blob/55ab3c581224accd575d3802e6e557a037129a46/pontoon/base/static/css/boilerplate.css#L2C3-L2C22

It's possible that the GitHub repo of the library didn't even exist when we started using it. Adrian might have took the code from some other place in our codebase.

I'm in favour of switching to h5bp/html5-boilerplate as you propose.

haastrupea commented 1 year ago

Alright. I will get started with the switching.