mozilla / pontoon

Mozilla's Localization Platform
https://pontoon.mozilla.org
BSD 3-Clause "New" or "Revised" License
1.47k stars 528 forks source link

Spellchecking not working anymore #2881

Closed gion-andri closed 1 year ago

gion-andri commented 1 year ago

It appears that there has been a recent update in Pontoon, containing a modification of the translation input field from a textarea to a div element.

Consequently, this change has caused the integrated spellchecking feature of Firefox (and probably other browsers) to cease functioning.

As correct spelling is quite an important aspect in Ponton, please find a was to re-enable that.

flodolo commented 1 year ago

I see spellcheck="false" analyzing the code 🤔

Manually flipping that it seems to work, I wonder why they disable it.

EDIT: this is probably useful (and worrying)? The spellchecking kicks in very late in this demo, when you leave the editor or go on a new line.

eemeli commented 1 year ago

Based on this comment, enabling spellcheck via contentAttributes ought to "just work".

EDIT: this is probably useful (and worrying)? The spellchecking kicks in very late in this demo, when you leave the editor or go on a new line.

Both of those examples use CM5, and CM6 is completely different.

flodolo commented 1 year ago

I'm not seeing spellchecking enabled in Firefox, even if I force reload the page. https://pontoon.mozilla.org/it/mozillaorg/all-resources/?status=unreviewed&string=281232

I also still see the spellcheck="false" in the code.

mathjazz commented 1 year ago

Are logged in?

Is it the same in the private mode?

What about in the Firefox troubleshooting mode?

flodolo commented 1 year ago

Are logged in?

Yes, otherwise the editor is disabled (not editable).

Is it the same in the private mode? What about in the Firefox troubleshooting mode?

It works on a different profile with Firefox release.

Apparently, it doesn't work with this add-on, while it was working just fine with a textarea https://addons.mozilla.org/firefox/addon/languagetool/

I suppose that's a problem in Firefox and not Pontoon, still annoying :-(