search

mozilla / popcorn-js

The HTML5 Media Framework. (Unmaintained. See https://github.com/menismu/popcorn-js for activity)
MIT License
2.14k stars 631 forks source link

Sequencer Plugin outside butter ? #347

Closed Ventricule closed 10 years ago

Ventricule commented 11 years ago

Hello,

I try to use the sequencer plugin ( not sequence, sequencer, the one in use on popcorn.webmaker : https://github.com/mozilla/butter/blob/master/public/templates/assets/plugins/sequencer/popcorn.sequencer.js ) for my popcorn. But that dont work, chrome report " Object # has no method 'trim' ". It should have Butter dependencies.

Is there a way to use this plugin without deploy butter ?

ScottDowne commented 11 years ago

It is possible, or was and can be again but it takes a bit of work. I had an example on my github that might help. I can link it once I get home.

It is not dependent on butter but is dependent on our controls. So that is probably what you are hitting. On 2013-09-28 10:27 AM, "Ventricule" notifications@github.com wrote:

Hello,

I try to use the sequencer plugin ( not sequence, sequencer, the one in use on popcorn.webmaker : https://github.com/mozilla/butter/blob/master/public/templates/assets/plugins/sequencer/popcorn.sequencer.js) for my popcorn. But that dont work, chrome report " Object # has no method 'trim' ". It should have Butter dependencies.

Is there a way to use this plugin without deploy butter ?

— Reply to this email directly or view it on GitHubhttps://github.com/mozilla/popcorn-js/issues/347 .

ScottDowne commented 11 years ago

I setup this example file: https://github.com/mozilla/butter/pull/1600/files

That should get you very very close to getting sequencer working outside of popcorn maker, although I still needed all our utils modules. I had to load in controls, which, I think loaded in a few others, which loaded in a few others, it was however just utils and not popcorn maker itself. Sometimes modules are not the best :(

This line right here: https://github.com/mozilla/butter/pull/1600/files#diff-81993ce5c02597e8976568fdedeeaf26R66 is where I start loading in utils.

The current master for popcorn maker may of changed, so best to start with using the utils attached to the repo in that commit, and not master utils.

Anyway, let me know if you have some luck, and I'm willing to help you get it working.

On 29 September 2013 17:23, Scott Downe scott.downe@gmail.com wrote:

It is possible, or was and can be again but it takes a bit of work. I had an example on my github that might help. I can link it once I get home.

It is not dependent on butter but is dependent on our controls. So that is probably what you are hitting. On 2013-09-28 10:27 AM, "Ventricule" notifications@github.com wrote:

Hello,

I try to use the sequencer plugin ( not sequence, sequencer, the one in use on popcorn.webmaker : https://github.com/mozilla/butter/blob/master/public/templates/assets/plugins/sequencer/popcorn.sequencer.js) for my popcorn. But that dont work, chrome report " Object # has no method 'trim' ". It should have Butter dependencies.

Is there a way to use this plugin without deploy butter ?

— Reply to this email directly or view it on GitHubhttps://github.com/mozilla/popcorn-js/issues/347 .

Ventricule commented 11 years ago

Thank you Scott ! Yes man I'm lucky ! but actually its not enought. I tried to use your example ... but I still have the same error.

What I done :

That's all, have I to do something more ?

<!DOCTYPE html>
<html>
<head>
  <title>Popcorn Subtitle Plug-in Demo</title>
  <script src="http://popcornjs.org/code/dist/popcorn-complete.min.js"></script>
  <script src="plugins/sequencer/popcorn.sequencer.js"></script>
  <script src="plugins/sequencer/require.js"></script>
  <link href="plugins/sequencer/controls.css" rel="stylesheet">
  <style>
    .video {
      height: 100%;
      position: relative;
      width: 100%;
      z-index: 1;
      background-color: #FFF;
    }
    .controls {
      background: none repeat scroll 0 0 white;
      border: 1px solid #D5D6D5;
      bottom: 0;
      height: 41px;
      left: 0;
      opacity: 1;
      position: absolute;
      right: 0;
      visibility: visible;
      z-index: 2;
    }
  </style>
  <script>
    document.addEventListener( "DOMContentLoaded", function() {
      var p = Popcorn.smart( "#video", "#t=,120", { frameAnimation: true } )
      .volume( 0 )
      .sequencer({
        start: 0,
        end: 90,
        target: "video",
        width: 50,
        zindex: 2,
        duration: 90,
        source: "http://www.youtube.com/watch?v=QZB7OFRUrA0"
      })
      .sequencer({
        start: 30,
        end: 120,
        target: "video",
        left: 50,
        width: 50,
        zindex: 3,
        duration: 90,
        source: "http://www.youtube.com/watch?v=QZB7OFRUrA0"
      });

      var require = requirejs.config({
        baseUrl: "plugins/sequencer",
        paths: {
          "text": "text"
        }
      });

      define( "sequencer-example", [ "controls" ], function( Controls ) {
        p.controls( true );
        Controls.create( "controls", p );
      });
      require(["sequencer-example"]);
    }, false);
  </script>
</head>
<body>
  <h1>Popcorn Sequencer Plug-in Demo</h1>
  <div>
    <div id="video" style="position: relative; height: 200px; width: 500px;">
      <div class="video"></div>
    </div>
    <div id="controls" class="controls"><div>
  </div>
</body>
</html>

Thanks for your help !

Ventricule commented 11 years ago

Hey ScottDowne, I manage to make it work by copying all repos, now I will cleanup the unnecessary folders.

Now I have an other problem, deeper : thanks to popcorn, I can loop the "mod wolves dance" video used as exemple, but now I need to listen more songs as funny as that !

Ventricule commented 11 years ago

There is something else ( I feel bad to pollute the issue report, but the sequencer will be a very practical tool for my project, though say it if I bother you) : When I seek on the sequence, the videos seeks well, when one finish its zIndex change to 0 and the next change to 2 or 3, but when I seek back on the sequence, all the zIndex stay at 0... Do you know what it is ?

ScottDowne commented 11 years ago

It's not bother, finding bugs is a good thing and helps the both of us. I encourage it!

It looks like that version of sequencer is fairly old. The butter repo was forked, and we now do active development on https://github.com/mozilla/popcorn.webmaker.org

Try switching the sequencer file out for this: https://github.com/mozilla/popcorn.webmaker.org/blob/master/public/templates/assets/plugins/sequencer/popcorn.sequencer.js

The two project repos are fiarly similar, and plugins should be compatible, and the file/diractory structure should be similar. If you have any issues, try comparing files and use the ones on popcorn.webmaker over the ones on butter.

On 1 October 2013 10:10, Ventricule notifications@github.com wrote:

There is something else ( I feel bad to pollute the issue report, but the sequencer will be a very practical tool for my project, though say it if I bother you) : When I seek on the sequence, the videos seeks well, when one finish its zIndex change to 0 and the next change to 2 or 3, but when I seek back on the sequence, all the zIndex stay at 0... Do you know what it is ?

— Reply to this email directly or view it on GitHubhttps://github.com/mozilla/popcorn-js/issues/347#issuecomment-25452567 .

Ventricule commented 11 years ago

Nice, I was not quite sure if it was the right place for my question.

The new sequencer file work well with the olds Butter files. I tried to replace butter files by popcorn.webmaker files but it break. It seems to be something beetween bigPlayButton and classList.

But with the old files it work, so thats not perfect but that ok, I will try to make something with that tomorrow.

Ventricule commented 11 years ago

Hello,

I'm close to getting popcorn sequencer working... but I still have two problem I dont find the solution :

Do you have an idea to fix that ?

ScottDowne commented 11 years ago

I think it would be helpful to you and others in the future if I updated my demo to work out of the box.

I'm likely to hit the issues you're hitting. Would be easier to debug on my end, and I end up with something others can use.

I'm pretty busy until early next week, but once I get free time it should only take a day or so to get it up to date.

For now though, if you have not already, ensure the popcorn.js, and youtube and vimeo wrapper files match the ones in this repo: https://github.com/mozilla/popcorn-js/tree/82c80e3e39e163a65c0e2644d08e1e5018c945e9

That repo is the state the repo was in at the last known time the sequencer worked on its own.

I'm fairly convinced any issues you are and have been hitting are due to older bugs we have fixed in the up to date versions, or bugs caused by incompatibility between versions. So I'm very curious what I find when I try to update the example. Could be a new bug!

On 3 October 2013 04:37, Ventricule notifications@github.com wrote:

Hello,

I'm close to getting popcorn sequencer working... but I still have two problem I dont find the solution :

  • Each time a vimeo video begin, the player stop (it work well with youtube).
  • When I seek beetween youtube videos, they dont activate and show (it work well with vimeo).

Do you have an idea to fix that ?

— Reply to this email directly or view it on GitHubhttps://github.com/mozilla/popcorn-js/issues/347#issuecomment-25606322 .

Ventricule commented 11 years ago

That should be GREAT ! Sure, thats a really intersting feature, for webdocs and this kind of stuff its perfect, it will be very usefull for future users.

I check if my files was the ones in the repos you give, some was not, I change them, but finally I have the same errors.

I update popcorn.maker files with last version, in controls.js I have to change function Controls( container, options ) { into function Controls( container, p, options ) { to make it work, . However p is undefined.

But I'm not coder, Im in the fog, sure you will understand in one minute what I understood in one hour !

That's really really nice you would like to update the demo, I will be really gracefull if you do it !

Ventricule commented 11 years ago

Hello ! It's just to know if there is anything new about the sequencer ? Hope you're not too busy !

ScottDowne commented 11 years ago

Yeah, sorry, been busy, but I have not forgotten! I'm trying to fit it in this week. Earlier rather than later.

On 15 October 2013 15:03, Ventricule notifications@github.com wrote:

Hello ! It's just to know if there is anything new about the sequencer ? Hope you're not too busy !

— Reply to this email directly or view it on GitHubhttps://github.com/mozilla/popcorn-js/issues/347#issuecomment-26362808 .

Ventricule commented 11 years ago

No problem ! :)

2013/10/15 ScottDowne notifications@github.com

Yeah, sorry, been busy, but I have not forgotten! I'm trying to fit it in this week. Earlier rather than later.

On 15 October 2013 15:03, Ventricule notifications@github.com wrote:

Hello ! It's just to know if there is anything new about the sequencer ? Hope you're not too busy !

— Reply to this email directly or view it on GitHub< https://github.com/mozilla/popcorn-js/issues/347#issuecomment-26362808> .

— Reply to this email directly or view it on GitHubhttps://github.com/mozilla/popcorn-js/issues/347#issuecomment-26363770 .

   ----------------------------
   Pierre Tandille

   www.lecollecteur.fr
ScottDowne commented 10 years ago

Doing this now, sorry for the delay.

It's something that's going to be checked right into the repo so it'll more likely be kept up to date.

You cna track the progress here: https://bugzilla.mozilla.org/show_bug.cgi?id=934428

On 15 October 2013 16:06, Ventricule notifications@github.com wrote:

No problem ! :)

2013/10/15 ScottDowne notifications@github.com

Yeah, sorry, been busy, but I have not forgotten! I'm trying to fit it in this week. Earlier rather than later.

On 15 October 2013 15:03, Ventricule notifications@github.com wrote:

Hello ! It's just to know if there is anything new about the sequencer ? Hope you're not too busy !

— Reply to this email directly or view it on GitHub< https://github.com/mozilla/popcorn-js/issues/347#issuecomment-26362808> .

— Reply to this email directly or view it on GitHub< https://github.com/mozilla/popcorn-js/issues/347#issuecomment-26363770> .

Pierre Tandille

www.lecollecteur.fr

— Reply to this email directly or view it on GitHubhttps://github.com/mozilla/popcorn-js/issues/347#issuecomment-26367529 .

Ventricule commented 10 years ago

That's great ! Thanks, I will track the process and if I find a way to help you I will do it.

2013/11/4 ScottDowne notifications@github.com

Doing this now, sorry for the delay.

It's something that's going to be checked right into the repo so it'll more likely be kept up to date.

You cna track the progress here: https://bugzilla.mozilla.org/show_bug.cgi?id=934428

On 15 October 2013 16:06, Ventricule notifications@github.com wrote:

No problem ! :)

2013/10/15 ScottDowne notifications@github.com

Yeah, sorry, been busy, but I have not forgotten! I'm trying to fit it in this week. Earlier rather than later.

On 15 October 2013 15:03, Ventricule notifications@github.com wrote:

Hello ! It's just to know if there is anything new about the sequencer ? Hope you're not too busy !

— Reply to this email directly or view it on GitHub< https://github.com/mozilla/popcorn-js/issues/347#issuecomment-26362808>

.

— Reply to this email directly or view it on GitHub< https://github.com/mozilla/popcorn-js/issues/347#issuecomment-26363770> .

Pierre Tandille

www.lecollecteur.fr

— Reply to this email directly or view it on GitHub< https://github.com/mozilla/popcorn-js/issues/347#issuecomment-26367529> .

— Reply to this email directly or view it on GitHubhttps://github.com/mozilla/popcorn-js/issues/347#issuecomment-27685054 .

   ----------------------------
   Pierre Tandille

   www.lecollecteur.fr
ScottDowne commented 10 years ago

Got it working on my end. I made a github pull request and branch you can find here:

https://github.com/mozilla/popcorn.webmaker.org/pull/295

I see why it wasn't working for you.

I think it was the preload logic we added that was snagging you. My update should deal with that.

Let me know if that does the trick or not, because if it doesn't I should fix it before potentially landing it. No rush though.

On 4 November 2013 10:27, Ventricule notifications@github.com wrote:

That's great ! Thanks, I will track the process and if I find a way to help you I will do it.

2013/11/4 ScottDowne notifications@github.com

Doing this now, sorry for the delay.

It's something that's going to be checked right into the repo so it'll more likely be kept up to date.

You cna track the progress here: https://bugzilla.mozilla.org/show_bug.cgi?id=934428

On 15 October 2013 16:06, Ventricule notifications@github.com wrote:

No problem ! :)

2013/10/15 ScottDowne notifications@github.com

Yeah, sorry, been busy, but I have not forgotten! I'm trying to fit it in this week. Earlier rather than later.

On 15 October 2013 15:03, Ventricule notifications@github.com wrote:

Hello ! It's just to know if there is anything new about the sequencer ? Hope you're not too busy !

— Reply to this email directly or view it on GitHub<

https://github.com/mozilla/popcorn-js/issues/347#issuecomment-26362808>

.

— Reply to this email directly or view it on GitHub< https://github.com/mozilla/popcorn-js/issues/347#issuecomment-26363770>

.

Pierre Tandille

www.lecollecteur.fr

— Reply to this email directly or view it on GitHub< https://github.com/mozilla/popcorn-js/issues/347#issuecomment-26367529> .

— Reply to this email directly or view it on GitHub< https://github.com/mozilla/popcorn-js/issues/347#issuecomment-27685054> .

Pierre Tandille

www.lecollecteur.fr

—

Reply to this email directly or view it on GitHubhttps://github.com/mozilla/popcorn-js/issues/347#issuecomment-27693350 .

Ventricule commented 10 years ago

Hello Scott, Sorry for the delay, I was travelling. That's good, it work like a charm !

I thought the plugin will work like other popcorns plugins, I mean without require.js, controls.js, and with popcorn loaded directly with popcorn-complete.min.js and not part by part. But that should be a lot of work ! Actually I copy all the "public" folder in my project directory, and my player file use this directory to load popcorn, sequencer and dependancies. Its a bit dirty, but its working, so its the important point.

Thanks a lot for your work and your help !

ScottDowne commented 10 years ago

Great, glad I could help.

On 13 November 2013 09:10, Ventricule notifications@github.com wrote:

Closed #347 https://github.com/mozilla/popcorn-js/issues/347.

— Reply to this email directly or view it on GitHubhttps://github.com/mozilla/popcorn-js/issues/347 .

alien09 commented 9 years ago

To add more plugins in popcorn ...what have to do....can anyone suggest...already tried but could not..