Test 34 typo makes it fail with an exception.

mozilla / popcorn-js

The HTML5 Media Framework. (Unmaintained. See https://github.com/menismu/popcorn-js for activity)

MIT License

2.14k stars 632 forks source link

Test 34 typo makes it fail with an exception. #426

Closed TwoD closed 9 years ago

TwoD commented 9 years ago

The variable "canPlayFired" is undefined because it's declared as "canplayFired". When everything is ok the "canPlayFired" variable will be created (globally!) when the "canplay" event fires and the problem is not noticed. But if "canplay" hasn't been fired before "play", an exception will be thrown when asserting the value of "canPlayFired".

ScottDowne commented 9 years ago

Good catch!

TwoD commented 9 years ago

Thanks for the quick merge!