search

mozilla / popcorn-js

The HTML5 Media Framework. (Unmaintained. See https://github.com/menismu/popcorn-js for activity)
MIT License
2.14k stars 632 forks source link

Proper way to update TrackEvents ? #443

Open JpEncausse opened 9 years ago

JpEncausse commented 9 years ago

Hi, I have a GUI like popcorn webmaker to display events on a track. I add events with the folowing code:

popcorn.myplugin({ start: 1, end: 2, duration: 1, custiom: 'x' });

What is the proper way to clear this event or all events when my GUI update the start / end ? I assume clearing popcorn.data.trackEvents is not enought :-)

Should I provide an Id ? If yes I assume it should be something like myInternalId + '_' + start ?

Regards, Jp

mjschranz commented 9 years ago

If you want to remove all trackEvents period you will need to simply loop over them and call popcorn.removeTrackEvent( trackEvent._id ). You can provide your own ID when creating a plugin in the format of p.myplugin({ id; 'asdf' })

Clearing popcorn.data.trackEvents is generally speaking a bad idea.