Open cvcmatthewmorgan opened 9 years ago
I understand that this might be a continuation to #430 but I felt this was a separate issue to do with the same section of code.
I am happy to contribute a pull request to fix the issue along with #430 but would like to discuss workflow here first.
Given the use of the following code, the start time is ignored.
document.addEventListener("DOMContentLoaded", function() { var popcorn = Popcorn.smart("#video", "http://www.youtube.com/watch?v=eTKs27KcL00&t=10s"); }, false);
In the middle of onFirstPlay() there is a line that resets the video back to 0 which causes this to occur.
onFirstPlay()
Suggested changes:
start
t
player.seekTo()
preload()
I understand that this might be a continuation to #430 but I felt this was a separate issue to do with the same section of code.
I am happy to contribute a pull request to fix the issue along with #430 but would like to discuss workflow here first.
Given the use of the following code, the start time is ignored.
In the middle of
onFirstPlay()
there is a line that resets the video back to 0 which causes this to occur.Suggested changes:
onFirstPlay()
makes use of thestart
ort
player variables instead of always going to 0.onFirstPlay()
should be triggered ifplayer.seekTo()
is going to be triggered or ifpreload()
is required.onFirstPlay()
should not pause if autoplay is true.