mozilla / popcorn.webmaker.org

RETIRED
https://blog.mozilla.org/foundation-archive/mozilla-learning/product-update-for-appmaker-and-popcorn-maker/
MIT License
146 stars 116 forks source link

Fix mime-type detection for urls #543

Closed joshuawarner32 closed 10 years ago

joshuawarner32 commented 10 years ago

Previously, pasted media urls with '?' in them (among other things, probably) caused mime detection, via node-hubble.mofoprod.net to fail. Node-hubble truncated the url at the '?', causing it to try detecting the mime type of the wrong url.

For a concrete example, pasting in the following url (file id redacted) previously caused a 'This media source is unplayable' error because it was getting back a mime type of text/plain (an error page, actually):

https://ec2cdn6.callinfo.com/cloudProxy/cloudProxy?request=https://cc.readytalk.com/cc/s/media/file/REDACTED_UUID/video.mp4

With this fix, the url works swimmingly.