search

mozilla / positron

a experimental, Electron-compatible runtime on top of Gecko
Other
564 stars 64 forks source link

Implement process.platform (fixes #8) #10

Closed mykmelez closed 8 years ago

mykmelez commented 8 years ago

Based on https://github.com/mykmelez/positron/tree/renderer-process-modules:

https://github.com/mykmelez/positron/compare/renderer-process-modules...implement-process-platform

khuey commented 8 years ago

@marcoscaceres you've been looking at this, want to merge it if you're satisfied?

marcoscaceres commented 8 years ago

@khuey, I don't have merge rights. Happy to be added to the project to help with reviews, and implementing things (I'm sure @overholt won't mind me working on this as part of platform).

marcoscaceres commented 8 years ago

@mykmelez, you mentioned that parts of this PR were done as part of https://github.com/mozilla/positron/commit/82d3ce92b4b36c8e72431d4ac53387396570cc30 - but those changes are not part of this PR. Does this need a rebase?

mykmelez commented 8 years ago

@mykmelez, you mentioned that parts of this PR were done as part of 82d3ce9 - but those changes are not part of this PR. Does this need a rebase?

It does indeed. Done!

marcoscaceres commented 8 years ago

@mykmelez ok cool, R+ from me. Merge if ready.

mykmelez commented 8 years ago

@mykmelez ok cool, R+ from me. Merge if ready.

Ok, merged, but you've been given privileges, so you should be able to merge PRs yourself now!

marcoscaceres commented 8 years ago

Ok, merged, but you've been given privileges, so you should be able to merge PRs yourself now!

Will do :)