search

mozilla / positron

a experimental, Electron-compatible runtime on top of Gecko
Other
562 stars 64 forks source link

hide iframe border that Gecko adds by default #101

Closed mykmelez closed 8 years ago

mykmelez commented 8 years ago

This doesn't manifest in the sample browser, strangely, perhaps because it applies some style rule to the iframe, but the <iframe mozbrowser> in the shadow DOM of the <webview> element is surrounded by a 2px border when a <webview> is placed into a simple app without any other styling.

And since the <iframe> is an internal implementation detail, it shouldn't express visible style. Apps that want a border around the <webview> can always add one themselves. (Electron doesn't display such a border by default, so this change also improves Electron compatibility.)

Ryuno-Ki commented 8 years ago

At work, we assigned seamless="seamless" to iframes (experimental) next to setting the border style to 0.

mykmelez commented 8 years ago

At work, we assigned seamless="seamless" to iframes (experimental) next to setting the border style to 0.

Interesting. The status of the seamless attribute isn't clear, as https://developer.mozilla.org/en-US/docs/Web/API/HTMLIFrameElement marks it experimental, while https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe doesn't.

Also, it doesn't appear in the HTML5 recommendation nor the HTML5 living standard.

Regardless, it isn't supported by Gecko, so we can't use it in this case.

mykmelez commented 8 years ago

@brendandahl can you review this PR?