After merging @jryans's devtools branch, I noticed this error when quitting the "hello world" app: JavaScript error: … resource:///modules/gecko/atom_browser_window.js, line 71: TypeError: browserWindow is undefined. Presumably it's because the observer gets a notification about the devtools window closing, but that window isn't a BrowserWindow, so it isn't found in browserWindows. Thus this branch ensures browserWindow before trying to use it.
After merging @jryans's devtools branch, I noticed this error when quitting the "hello world" app:
JavaScript error: … resource:///modules/gecko/atom_browser_window.js, line 71: TypeError: browserWindow is undefined
. Presumably it's because the observer gets a notification about the devtools window closing, but that window isn't a BrowserWindow, so it isn't found inbrowserWindows
. Thus this branch ensures browserWindow before trying to use it.